Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fix_random in xfail backward tests #8419

Merged
merged 1 commit into from Nov 13, 2019

Conversation

toslunar
Copy link
Member

The PR fixes #8162.

backward test with random direction may unexpectedly pass.
@toslunar toslunar added cat:test Test or CI related. to-be-backported Pull request that should be backported. labels Nov 12, 2019
@niboshi
Copy link
Member

niboshi commented Nov 13, 2019

Jenkins, test this please

@niboshi niboshi modified the milestones: v6.6.0, v7.0.0 Nov 13, 2019
@niboshi niboshi added the st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. label Nov 13, 2019
@chainer-ci
Copy link
Member

Jenkins CI test (for commit 5b7f49b, target branch master) succeeded!

@mergify mergify bot merged commit 6fb2fc4 into chainer:master Nov 13, 2019
@toslunar toslunar deleted the xfail-backward branch November 13, 2019 09:33
@chainer-ci
Copy link
Member

@niboshi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

niboshi pushed a commit to niboshi/chainer that referenced this pull request Nov 19, 2019
Use `fix_random` in xfail backward tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat:test Test or CI related. st:test-and-merge State indicating that pull request is approved by a reviewer and can be merged after CI passes. to-be-backported Pull request that should be backported.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test: chainer_tests/testing_tests/test_function_link.py::TestLinkIncorrectBackwardInput
3 participants