diff --git a/state-chain/TROUBLESHOOTING.md b/state-chain/TROUBLESHOOTING.md index fded58363e..995b2c9d59 100644 --- a/state-chain/TROUBLESHOOTING.md +++ b/state-chain/TROUBLESHOOTING.md @@ -23,7 +23,8 @@ SKIP_WASM_BUILD=1 cargo build --release --features=try-runtime Now you can run your tests like so (using an appropriate public rpc node): ```sh -./target/release/chainflip-node try-runtime --execution native \ +./target/release/chainflip-node try-runtime \ + --runtime ./path/to/state_chain_runtime.wasm \ on-runtime-upgrade live --uri wss://perseverance.chainflip.xyz:443 ``` @@ -48,8 +49,6 @@ Once the node has synced, in another terminal window, run the checks: on-runtime-upgrade live --uri ws://localhost:9944 ``` -> *Note: Using `--execution native` ensures faster execution and also prevents log messages from being scrubbed. - ### General tips and guidelines - There are some useful storage conversion utilities in `frame_support::storage::migration`. diff --git a/state-chain/runtime-upgrade-utilities/src/lib.rs b/state-chain/runtime-upgrade-utilities/src/lib.rs index c5dfa0b6ed..37cead8be3 100644 --- a/state-chain/runtime-upgrade-utilities/src/lib.rs +++ b/state-chain/runtime-upgrade-utilities/src/lib.rs @@ -31,83 +31,56 @@ pub struct VersionedMigration< #[cfg(feature = "try-runtime")] mod try_runtime_helpers { - use frame_support::traits::PalletInfoAccess; - use sp_std::vec::Vec; - - #[cfg(feature = "std")] - pub use with_std::*; - - #[cfg(not(feature = "std"))] - pub use without_std::*; - - #[cfg(feature = "std")] - mod with_std { - use super::*; - use core::cell::RefCell; - use sp_std::{ - cmp::{max, min}, - collections::btree_map::BTreeMap, - }; - - thread_local! { - pub static MIGRATION_BOUNDS: RefCell> = Default::default(); - #[allow(clippy::type_complexity)] - pub static MIGRATION_STATE: RefCell>>> = Default::default(); - } - - pub fn update_migration_bounds() { - MIGRATION_BOUNDS.with(|cell| { - cell.borrow_mut() - .entry(T::name()) - .and_modify(|(from, to)| { - *from = min(*from, FROM); - *to = max(*to, TO); - }) - .or_insert((FROM, TO)); - }); - } - - pub fn get_migration_bounds() -> Option<(u16, u16)> { - MIGRATION_BOUNDS.with(|cell| cell.borrow().get(T::name()).copied()) - } - - pub fn save_state(s: Vec) { - MIGRATION_STATE - .with(|cell| cell.borrow_mut().entry(T::name()).or_default().insert((FROM, TO), s)); - } - - pub fn restore_state() -> Vec { - MIGRATION_STATE.with(|cell| { - cell.borrow() - .get(T::name()) - .cloned() - .unwrap_or_default() - .get(&(FROM, TO)) - .cloned() - .unwrap_or_default() - }) - } + use frame_support::{pallet_prelude::ValueQuery, storage_alias, traits::PalletInfoAccess}; + use sp_std::{ + cmp::{max, min}, + collections::btree_map::BTreeMap, + vec::Vec, + }; + + #[storage_alias] + pub type MigrationBounds = + StorageValue, (u16, u16)>, ValueQuery>; + + #[storage_alias] + pub type MigrationState = StorageValue< + CfUpgradeUtilities, + BTreeMap, BTreeMap<(u16, u16), Vec>>, + ValueQuery, + >; + + pub fn update_migration_bounds() { + MigrationBounds::mutate(|bounds| { + bounds + .entry(T::name().as_bytes().to_vec()) + .and_modify(|(from, to)| { + *from = min(*from, FROM); + *to = max(*to, TO); + }) + .or_insert((FROM, TO)); + }); } - #[cfg(not(feature = "std"))] - mod without_std { - use super::*; - - pub fn update_migration_bounds() { - log::warn!("❗️ Runtime upgrade utilities are not supported in no-std."); - } - - pub fn get_migration_bounds() -> Option<(u16, u16)> { - Default::default() - } + pub fn get_migration_bounds() -> Option<(u16, u16)> { + MigrationBounds::get().get(T::name().as_bytes()).copied() + } - pub fn save_state(s: Vec) { - log::warn!("❗️ Runtime upgrade utilities are not supported in no-std."); - } + pub fn save_state(s: Vec) { + MigrationState::mutate(|state| { + state.entry(T::name().as_bytes().to_vec()).or_default().insert((FROM, TO), s) + }); + } - pub fn restore_state() -> Vec { - Default::default() - } + pub fn restore_state() -> Vec { + MigrationState::mutate(|state| { + state + .get(T::name().as_bytes()) + .cloned() + .unwrap_or_default() + .get(&(FROM, TO)) + .cloned() + .unwrap_or_default() + }) } }