Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: storage migration delete NextCompatibilityVersion #4115

Merged
merged 2 commits into from
Oct 13, 2023

Conversation

kylezs
Copy link
Contributor

@kylezs kylezs commented Oct 13, 2023

Pull Request

Closes: PRO-903

Checklist

Please conduct a thorough self-review before opening the PR.

  • I am confident that the code works.
  • I have updated documentation where appropriate.

Summary

Probably should've been done in the other PR: #4098 , but this is the next best thing.

@linear
Copy link

linear bot commented Oct 13, 2023

PRO-901 Remove `NextCompatibilityVersion` from the environment pallet

Instead of needing to submit and store a NextCompatibilityVersion in the environment pallet before we do a runtime upgrade, we can supply the required compatibility version as part of the runtime upgrade extrinsic, and achieve the same behaviour.

@kylezs kylezs requested a review from dandanlen October 13, 2023 08:50
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #4115 (289b4e3) into main (f61e2f0) will decrease coverage by 0%.
Report is 1 commits behind head on main.
The diff coverage is 0%.

@@          Coverage Diff          @@
##            main   #4115   +/-   ##
=====================================
- Coverage     72%     72%   -0%     
=====================================
  Files        377     378    +1     
  Lines      60625   60623    -2     
  Branches   60625   60623    -2     
=====================================
- Hits       43488   43479    -9     
- Misses     14878   14882    +4     
- Partials    2259    2262    +3     
Files Coverage Δ
state-chain/pallets/cf-environment/src/lib.rs 76% <ø> (ø)
...-chain/pallets/cf-environment/src/migrations/v5.rs 0% <0%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dandanlen dandanlen changed the title chore: delete NextCompatibilityVersion from storage chore: storage migration delete NextCompatibilityVersion Oct 13, 2023
@dandanlen dandanlen enabled auto-merge (squash) October 13, 2023 11:41
@dandanlen
Copy link
Collaborator

Needs cargo fmt..

@dandanlen dandanlen merged commit 99c3e0a into main Oct 13, 2023
44 checks passed
@dandanlen dandanlen deleted the chore/delete-next-compat-version branch October 13, 2023 12:46
@linear
Copy link

linear bot commented Oct 16, 2023

syan095 added a commit that referenced this pull request Oct 17, 2023
* origin/main:
  chore: get gas parameters from statechain event (#4125)
  Feat: ingress-egress tracking for DOT (#4121)
  add support for hex encoded amounts on limit order and range order methods in LP API (#4120)
  feat: bouncer command for submitting runtime upgrades (#4122)
  Feat: ensure correct process termination in ingress/egress tracker (#4101)
  feat(custom-rpc): add flip balance to account info (#4119)
  chore: storage migration delete NextCompatibilityVersion (#4115)
  chore: delete unneeded function (#4116)

# Conflicts:
#	state-chain/runtime/src/lib.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants