From 567eea185cf7b0569033f50983c5d9ab306207ca Mon Sep 17 00:00:00 2001 From: Matt Moore Date: Tue, 20 Feb 2024 18:01:08 -0800 Subject: [PATCH] Expand the list of modules we validate. (#155) Signed-off-by: Matt Moore --- .github/workflows/validate.yaml | 5 +++++ modules/cron/main.tf | 2 +- modules/prober/main.tf | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/workflows/validate.yaml b/.github/workflows/validate.yaml index ca7bd061..05e583ff 100644 --- a/.github/workflows/validate.yaml +++ b/.github/workflows/validate.yaml @@ -11,6 +11,7 @@ jobs: fail-fast: false matrix: module: + - audit-serviceaccount - authorize-private-service - cloudevent-broker - cloudevent-trigger @@ -22,6 +23,10 @@ jobs: - dashboard/service - dashboard/job - dashboard/cloudevent-receiver + - prober + - cron + - configmap + - secret steps: - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1 diff --git a/modules/cron/main.tf b/modules/cron/main.tf index 287074ef..aeab80aa 100644 --- a/modules/cron/main.tf +++ b/modules/cron/main.tf @@ -155,7 +155,7 @@ module "audit-delivery-serviceaccount" { # Note: Cloud Scheduler's usage doesn't show up in the # audit logs. - # TODO(mattmoor): plumb through notification channels. + notification_channels = var.notification_channels } resource "google_cloud_run_v2_job_iam_binding" "authorize-calls" { diff --git a/modules/prober/main.tf b/modules/prober/main.tf index 692d59b7..0c417d68 100644 --- a/modules/prober/main.tf +++ b/modules/prober/main.tf @@ -57,6 +57,8 @@ module "this" { } } } + + notification_channels = var.notification_channels } data "google_cloud_run_v2_service" "this" {