diff --git a/app/cli/cmd/plugins.go b/app/cli/cmd/plugins.go index be00c72cd..8db0f618c 100644 --- a/app/cli/cmd/plugins.go +++ b/app/cli/cmd/plugins.go @@ -245,7 +245,6 @@ func newPluginDescribeCmd() *cobra.Command { func newPluginInstallCmd() *cobra.Command { var file string - var filename string var location string cmd := &cobra.Command{ @@ -257,7 +256,6 @@ func newPluginInstallCmd() *cobra.Command { opts := &action.PluginInstallOptions{ File: file, - Filename: filename, Location: location, } @@ -272,8 +270,7 @@ func newPluginInstallCmd() *cobra.Command { } // Common flags - cmd.Flags().StringVarP(&file, "file", "f", "", "URL of the plugin to download (required)") - cmd.Flags().StringVarP(&filename, "filename", "", "", "Custom filename to save the plugin as (optional)") + cmd.Flags().StringVarP(&file, "file", "f", "", "URL or path to the plugin to install") cobra.CheckErr(cmd.MarkFlagRequired("file")) return cmd diff --git a/app/cli/documentation/cli-reference.mdx b/app/cli/documentation/cli-reference.mdx index d4f14c6b7..71da46184 100755 --- a/app/cli/documentation/cli-reference.mdx +++ b/app/cli/documentation/cli-reference.mdx @@ -1281,9 +1281,8 @@ chainloop config plugin install [flags] Options ``` --f, --file string URL of the plugin to download (required) ---filename string Custom filename to save the plugin as (optional) --h, --help help for install +-f, --file string URL or path to the plugin to install +-h, --help help for install ``` Options inherited from parent commands diff --git a/app/cli/internal/action/plugin_actions.go b/app/cli/internal/action/plugin_actions.go index 7bfeab99b..dbf01528b 100644 --- a/app/cli/internal/action/plugin_actions.go +++ b/app/cli/internal/action/plugin_actions.go @@ -172,10 +172,7 @@ func (action *PluginInstall) Run(_ context.Context, opts *PluginInstallOptions) // determine filename filename := filepath.Base(opts.File) - if opts.Filename != "" { - filename = opts.Filename - action.cfg.Logger.Debug().Str("customFilename", opts.Filename).Msg("Using custom filename") - } else if filename == "." || filename == "/" { + if filename == "." || filename == "/" { action.cfg.Logger.Error().Str("file", opts.File).Msg("Invalid URL or object key, could not determine filename") return nil, fmt.Errorf("invalid URL or object key, could not determine filename") }