From 22a3bae976322e483bad70111b5d5d2e16dda86f Mon Sep 17 00:00:00 2001 From: Miguel Martinez Trivino Date: Thu, 27 Jul 2023 16:49:50 +0200 Subject: [PATCH] feat: do not fail on cas backend Signed-off-by: Miguel Martinez Trivino --- app/controlplane/internal/service/cascredential.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/controlplane/internal/service/cascredential.go b/app/controlplane/internal/service/cascredential.go index 98be1c844..5c1258ebc 100644 --- a/app/controlplane/internal/service/cascredential.go +++ b/app/controlplane/internal/service/cascredential.go @@ -58,14 +58,19 @@ func (s *CASCredentialsService) Get(ctx context.Context, req *pb.CASCredentialsS } // Get repository to provide the secret name - repo, err := s.ociUC.FindDefaultBackend(ctx, currentOrg.ID) + backend, err := s.ociUC.FindDefaultBackend(ctx, currentOrg.ID) if err != nil && !biz.IsNotFound(err) { return nil, sl.LogAndMaskErr(err, s.log) - } else if repo == nil { + } else if backend == nil { return nil, errors.NotFound("not found", "main repository not found") } - t, err := s.casUC.GenerateTemporaryCredentials(repo.SecretName, role) + // If we want to upload an artifact but we have selected an inline backend we fail + if backend.Provider == biz.CASBackendInline { + return nil, errors.BadRequest("invalid argument", "cannot upload or download artifacts from an inline CAS backend") + } + + t, err := s.casUC.GenerateTemporaryCredentials(backend.SecretName, role) if err != nil { return nil, sl.LogAndMaskErr(err, s.log) }