From 22cc402983df23d6518bfa388b50ec83c2245967 Mon Sep 17 00:00:00 2001 From: Mattia Buccarella Date: Wed, 15 Nov 2023 18:53:03 +0100 Subject: [PATCH 1/2] fix(runner): remove optional env variable from the requirements Signed-off-by: Mattia Buccarella --- internal/attestation/crafter/runners/circleci_build.go | 1 - 1 file changed, 1 deletion(-) diff --git a/internal/attestation/crafter/runners/circleci_build.go b/internal/attestation/crafter/runners/circleci_build.go index b2f5fab6e..32bbb1b0c 100644 --- a/internal/attestation/crafter/runners/circleci_build.go +++ b/internal/attestation/crafter/runners/circleci_build.go @@ -43,7 +43,6 @@ func (r *CircleCIBuild) ListEnvVars() []string { // Some info about the commit "CIRCLE_BRANCH", - "CIRCLE_PR_NUMBER", // Some info about the agent "CIRCLE_NODE_TOTAL", From 97fd1f865c6ed066e406aa92b4a7ac97ad6fb6af Mon Sep 17 00:00:00 2001 From: Mattia Buccarella Date: Wed, 15 Nov 2023 18:53:36 +0100 Subject: [PATCH 2/2] fix tests Signed-off-by: Mattia Buccarella --- internal/attestation/crafter/runners/circleci_build_test.go | 2 -- 1 file changed, 2 deletions(-) diff --git a/internal/attestation/crafter/runners/circleci_build_test.go b/internal/attestation/crafter/runners/circleci_build_test.go index 14bf3675e..ced160b1c 100644 --- a/internal/attestation/crafter/runners/circleci_build_test.go +++ b/internal/attestation/crafter/runners/circleci_build_test.go @@ -92,7 +92,6 @@ func (s *circleCIBuildSuite) TestListEnvVars() { "CIRCLE_BUILD_URL", "CIRCLE_JOB", "CIRCLE_BRANCH", - "CIRCLE_PR_NUMBER", "CIRCLE_NODE_TOTAL", "CIRCLE_NODE_INDEX", }, s.runner.ListEnvVars()) @@ -123,7 +122,6 @@ var circleCIBuildTestingEnvVars = map[string]string{ "CIRCLE_BUILD_URL": "http://some-build-url/", "CIRCLE_JOB": "some-job", "CIRCLE_BRANCH": "some-branch", - "CIRCLE_PR_NUMBER": "1337", "CIRCLE_NODE_TOTAL": "3", "CIRCLE_NODE_INDEX": "1", }