Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Run ESlint during CI #119

Merged
merged 3 commits into from Apr 9, 2019

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented Mar 22, 2019

This pull request lays some foundations for the Introduce JavaScript testing framework task mentioned in the Feature Ideas.

As a first step to ensure the quality of the JavaScript code, this pull request forces ESlint to be run during the CI. In the future once some JavaScript tests are included in the project, it will be very simple to extend the CI to also run the tests: just add another line similar to npm run lint to tools/ci.sh and we're good to go.

The pull request also fixes all the current simple ESlint failures and disables some others. In the future, I expect to re-activate some of the disabled rules and add more linting rules, e.g. for Vue, but for now I wanted to keep the changes small.

To make it easier to have access to all the CI requirements (Python, Node, etc.), this pull request also moves the Travis CI to be fully based on the Docker image so that we're in full control of the CI environment and can also very easily run the exact same CI steps which Travis executes locally as a developer.

@c-w c-w force-pushed the CatalystCode:enhancement/eslint-ci branch 5 times, most recently from a4e5147 to d8422f8 Mar 25, 2019

@c-w c-w force-pushed the CatalystCode:enhancement/eslint-ci branch from d8422f8 to e40a3e1 Mar 25, 2019

@Hironsan Hironsan merged commit a29e798 into chakki-works:master Apr 9, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Hironsan

This comment has been minimized.

Copy link
Member

commented Apr 9, 2019

Thanks!

@c-w c-w deleted the CatalystCode:enhancement/eslint-ci branch Apr 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.