Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Add button to delete documents on dataset page #193

Merged

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented May 13, 2019

This change adds a button the the dataset page which lets an admin delete documents from a project. This is useful to for example delete test data or clean up the dataset.

The button is implemented via a simple request to the existing delete endpoint in the documents API. Given that the dataset page is server-side rendered by Django, when the request is successful, we reload the page to reflect the new state of the dataset. Note that for simplicity and speed, the button does not prompt the user for confirmation.

Screenshot showing new document delete button

Resolves #21

@Hironsan Hironsan merged commit adb8035 into chakki-works:master May 22, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the CatalystCode:enhancement/delete-document branch May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.