Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/Encode username in Azure DATABASE_URL #206

Merged
merged 5 commits into from May 20, 2019

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Contributor

commented May 16, 2019

In the Azure deploy the database user is in the format user@server and it looks like furl doesn't deal well with that. URL-encoding the @ to %40 fixes the problem.

Resolves #203

@c-w c-w changed the title Bugfix/Correctly parse Azure database connection string Bugfix/Correctly format Azure database connection string May 16, 2019

@c-w c-w changed the title Bugfix/Correctly format Azure database connection string Bugfix/Encode username in Azure database connection string May 16, 2019

@c-w c-w changed the title Bugfix/Encode username in Azure database connection string Bugfix/Encode username in Azure DATABASE_URL May 16, 2019

Show resolved Hide resolved azuredeploy.json Outdated

cicorias and others added some commits May 17, 2019

@Hironsan Hironsan merged commit 3f630d6 into chakki-works:master May 20, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the CatalystCode:bugfix/azure-database-url branch May 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.