Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Document how to run tests #215

Conversation

Projects
None yet
3 participants
@c-w
Copy link
Contributor

commented May 22, 2019

Resolves #214

@erikamenezes

This comment has been minimized.

Copy link
Contributor

commented May 22, 2019

Suggestion: Add collectstatic as well?

Also, even though the django tests pass, the CI sometimes breaks due to some style guidelines. So I've found running the tools/ci.sh to be better.

@c-w

This comment has been minimized.

Copy link
Contributor Author

commented May 22, 2019

@erikamenezes Thanks for the suggestion. The need to run collectstatic before the tests will be removed as soon as #207 is merged so I wouldn't document this just now.

I'm hesitant to recommend tools/ci.sh as the default test runner since it won't work on Windows. Ideally we'd re-write the bash scripts in Python so that they can be run cross-platform. I can work on porting the tools to Python or even something slightly more complete like using fabfile or invoke. Thoughts @Hironsan?

@Hironsan

This comment has been minimized.

Copy link
Member

commented May 23, 2019

It is better to explain only how to run the basic test. It's executable for any developers.

@Hironsan Hironsan merged commit 801baf3 into chakki-works:master May 23, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the CatalystCode:enhancement/document-how-to-run-tests branch May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.