Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/Fix CoNLL parsing with trailing newlines #225

Merged

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Contributor

commented May 26, 2019

If a CoNLL file has a trailing newline, we currently silently don't import any data which may be confusing to the user (see for example #218). This pull request fixes the behavior and ensures that if data was correctly parsed from the file, it also gets imported.

@c-w c-w force-pushed the CatalystCode:bugfix/conll-with-trailing-newlines branch from 939ebd6 to 7c3116f May 26, 2019

@Hironsan Hironsan merged commit 9c9d223 into chakki-works:master May 31, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the CatalystCode:bugfix/conll-with-trailing-newlines branch May 31, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.