Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/Extend integration tests to cover SQL Server database #303

Merged

Conversation

@c-w
Copy link
Contributor

commented Jul 22, 2019

This pull request ensures that Doccano's support for SQL Server (introduced in #255) is covered in the database backend test infrastructure (introduced in in #278).

Given that the database backend tests run in the builder stage of the Dockerfile, this pull request also moves the SQL server system dependency setup into a script so that the code to install the dependencies doesn't have to be copy/pasted between the runtime and builder stages.

@Hironsan Hironsan merged commit 2c15111 into chakki-works:master Aug 7, 2019

2 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details

@c-w c-w deleted the CatalystCode:enhancement/test-mssql-database branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.