Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Add flake8 linter #74

Merged
merged 2 commits into from Jan 27, 2019

Conversation

Projects
3 participants
@c-w
Copy link
Contributor

commented Jan 25, 2019

In order to ensure a consistent code style and to find potential bugs not uncovered by tests, this change adds the flake8 linter to the project's CI.

The pull request also fixes all the existing flake8 violations:

  • F403 and F405: wildcard imports.
  • E501: line too long.
  • F481: unused variable.
  • E128, E231, E261, E265, E302, E303, W293, W291: whitespace.

@BrambleXu BrambleXu referenced this pull request Jan 25, 2019

Merged

Enhancement/shortcuts #73

3 of 3 tasks complete

@Hironsan Hironsan merged commit 0e6718a into chakki-works:master Jan 27, 2019

2 checks passed

Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@c-w c-w deleted the CatalystCode:feature/flake8 branch Jan 28, 2019

@BrambleXu BrambleXu added this to PR Status in v1.0.0 Jan 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.