Linux to Master #1526
Linux to Master #1526
Conversation
* synchronize changes made in dotnet/coreclr#4922
…treat symbolic links Merge pull request chakra-core#1393 from antonmes:linux Synchronize changes made by @adityamandaleeka in dotnet/coreclr#4922 Fixes build on macOS Sierra: `ChakraCore/pal/src/cruntime/filecrt.cpp:355:12: error: 'syscall' is deprecated: first deprecated in macOS 10.12 - syscall(2) is unsupported; please switch to a supported interface. For SYS_kdebug_trace use kdebug_signpost(). [-Werror,-Wdeprecated-declarations]`
issue: slow running, JSON/simple.withLog test was randomly failing on xplat. We provide string length internally. However customized PAL interface expects null ending. Apart from the fix, also removed unused PAL source files.
…ut bus error [pal] and format precision Merge pull request chakra-core#1423 from obastemur:unused issue: [slow running] JSON/simple.withLog test was randomly failing on xplat. [also crashing] CC provides string length internally. However customized PAL interface expects null ending. Apart from the fix, also removed unused PAL source files.
…tput for xplat Merge pull request chakra-core#1414 from obastemur:fix_biops_test
Cmake fails to update references
Merge pull request chakra-core#1430 from obastemur:m_merge
… build caching Merge pull request chakra-core#1431 from obastemur:fix_cmake_cache Cmake fails to update references
Merge pull request chakra-core#1443 from obastemur:linux_merge_master_3
…w just warnings) Merge pull request chakra-core#1442 from Fishrock123:fix-mac-compile-errors Fixes chakra-core#1436
Also added a simple sort test to trigger hybrid_sort implementation
See comments on disabled test case
…ble/disable some tests Merge pull request chakra-core#1455 from obastemur:ch_platform See comments on disabled test case Attempt to fix chakra-core#1397
…ed library) support [all tests pass] Merge pull request chakra-core#1473 from obastemur:osx_dylib
We have been keep breaking the native sample project. Fixing the break and adding a native test to make sure we do not break it again
…verlapping memory cases Merge pull request chakra-core#1450 from obastemur:fix_memmove Also added a simple sort test to trigger hybrid_sort implementation
…d break and add native testing Merge pull request chakra-core#1479 from obastemur:fix_lnx_break We've been keep breaking the native sample project. Fixing the break and adding a native test to make sure we do not break it again new WScript.Platform members : 'LINK_TYPE' and 'BINARY_PATH'
Some of the embedders (i.e. node-chakracore targets an earlier version of SDK)
Merge pull request chakra-core#1493 from obastemur:osx_108 Some of the embedders (i.e. node-chakracore targets an earlier version of SDK)
Some of the tests (slow running) randomly fails on default timeout. Although timeout can be set from command line for different set of runs, it is convenient to have a bigger timeout for slow running tests Affects `--include-slow` runs on unix/posix
…slow running tests 180 secs on *nix Merge pull request chakra-core#1452 from obastemur:running_slow Some of the tests (slow running) randomly fails on default timeout. Although timeout can be set from command line for different set of runs, it is convenient to have a bigger timeout for slow running tests Affects `--include-slow` runs on unix/posix
Saw this while fixing Regex fail on Fedora
Standard requires a call to va_end due to its undefined behavior.
Also submitted a PR to coreclr to fix the same issue there. This PR fixes the Regex/BoiHardFail.js on Fedora. Now we have all the tests are passing on Fedora
…or leak on PAL_IsDebuggerPresent Merge pull request chakra-core#1508 from obastemur:fix_fd_leak Also submitted a PR to coreclr to fix the same issue there. See dotnet/coreclr#6958 This PR fixes the Regex/BoiHardFail.js on Fedora. See chakra-core#1334 Now we have all the tests are passing on Fedora
…np false asserts Merge pull request chakra-core#1506 from obastemur:false_assert Saw this while fixing Regex fail on Fedora
… no-op Merge pull request chakra-core#1507 from obastemur:va_leaks Standard requires a call to va_end due to its undefined behavior.
obastemur
force-pushed
the
mmerge_10
branch
7 times, most recently
from
1c5a01b to
bd7c461
Compare
|
@agarwal-sandeep please review last commit From this PR forward we won't be using /cc @liminzhu we may want to update Wiki and other places? |
| @@ -2,19 +2,19 @@ | |||
| { | |||
| "callStack": [ | |||
| { | |||
| "line": 27, | |||
| "line": 29, | |||
There was a problem hiding this comment.
Since you changed the lines in file you will also need to update full repro baseline at [FullRepro]\unittest\DebuggerCommon\step_in_from_interpreted_function_attach.js.dbg.baseline. And since you need to update full baseline you may not do delete WScript.Platform and have Platform show in dbg baseline
There was a problem hiding this comment.
WScript.Platform is specific to ch
There was a problem hiding this comment.
Another solution is enabling WScript.Platform only when a specific ch flag is used though. This way we won't have similar issues going forward
There was a problem hiding this comment.
If WScript.Platform is not needed for majority of the cases then exposing it under a switch is ideal otherwise update the core baseline without modifying the test.
There was a problem hiding this comment.
I wish we could arbitrarily ignore certain objects from all our baselines: WScript, Debug, ... (may we attach and examine a special property, e.g. hide object data completely if it has property __hide_baseline__?)
There was a problem hiding this comment.
We do but only at top level under locals. Maybe we can revisit and fix ignoring at all levels.
|
@obastemur gotcha. After it's merged I'll point docs to master branch instead of Linux. |
|
@agarwal-sandeep Thanks for the review |
Merge pull request #1526 from obastemur:mmerge_10
No description provided.