Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): add default config settings #489

Merged

Conversation

carwack
Copy link
Collaborator

@carwack carwack commented Sep 21, 2021

Description

Add config option key to Chakra-ui-theme

Motivation and Context

We didn't make use of the config option key and cssVarPrefix that are available in the Chakra-UI/Styled-system package

How Has This Been Tested?

Not sure how to test this. Tried on a playground project.

Screenshots (if appropriate):

Screenshot 2021-09-20 at 11 35 28

Screenshot 2021-09-20 at 11 40 53

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2021

⚠️ No Changeset found

Latest commit: 16c663d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 21, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

chakra-ui-vue – ./

🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-vue/8z79WEgNTGx2A4Cdr1KC1HsM2EKr
✅ Preview: https://chakra-ui-vue-git-fork-carwack-feat-themeadd-d-98a439-chakra-ui.vercel.app

[Deployment for 16c663d canceled]

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 21, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 16c663d:

Sandbox Source
Chakra UI Vue (0.X) Starter Template Configuration
chakra-ui-nuxt-demo Configuration

@carwack carwack changed the title Feat/theme/add default config settings Feat(theme): add default config settings Sep 22, 2021
@carwack carwack changed the title Feat(theme): add default config settings feat(theme): add default config settings Sep 22, 2021
codebender828
codebender828 previously approved these changes Sep 23, 2021
Copy link
Collaborator

@codebender828 codebender828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @carwack

@codebender828
Copy link
Collaborator

Please run yarn test:core -u to update the snapshots before we merge this. @carwack

@vercel vercel bot temporarily deployed to Preview – chakra-ui-vue January 19, 2022 16:17 Inactive
@codebender828 codebender828 merged commit 2c04cfe into chakra-ui:develop Jan 19, 2022
@codebender828
Copy link
Collaborator

Thank you @carwack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: theme 🎨 To do with the Chakra theming type: feature or enhancement ⚡️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants