Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chakra Storybook Addon] Color mode switch breaks visual testing tools #5380

Closed
3 tasks
guilleironhack opened this issue Jan 13, 2022 · 2 comments · Fixed by #5922
Closed
3 tasks

[Chakra Storybook Addon] Color mode switch breaks visual testing tools #5380

guilleironhack opened this issue Jan 13, 2022 · 2 comments · Fixed by #5922
Labels
stale Topic: Storybook Addon Issues and PRs for the official Storybook Addon Type: Bug 🐛 Something isn't working

Comments

@guilleironhack
Copy link

Description

When using visual testing tools that take screenshots of stories, the color mode switch appears in all of them, triggering a false positives.

Link to Reproduction

N/A

Steps to reproduce

No response

Chakra UI Version

@chakra-ui/storybook-addon@1.0.0

Browser

No response

Operating System

  • macOS
  • Windows
  • Linux

Additional Information

Some example:
image

Ideally, the color mode selector should at the toolbar, or at least would be great to have the option to disable the color mode switcher.
@guilleironhack guilleironhack added needs triage Issues and pull requests that need triage attention Type: Bug 🐛 Something isn't working labels Jan 13, 2022
@TimKolberger TimKolberger added Topic: Storybook Addon Issues and PRs for the official Storybook Addon and removed needs triage Issues and pull requests that need triage attention labels Jan 13, 2022
@ngxCoder
Copy link
Contributor

If nobody else solves this, I will try to add an option to remove the color mode switcher this week.
I thought about this feature when I released it, but I am having some problems with my bills, haha

ngxCoder added a commit to ngxCoder/chakra-ui that referenced this issue Mar 14, 2022
@ngxCoder
feat(color mode switch): add configurable parameters
38c0a23 
Add enable, position, zIndex and margin as parameters to modify the component

"fix chakra-ui#5544", "fix chakra-ui#5380"
This was referenced Mar 14, 2022
Closed
Closed
@stale
Copy link

stale bot commented Apr 16, 2022

Hi!
This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs within 5 days. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@TimKolberger TimKolberger mentioned this issue Apr 24, 2022
Merged
@stale stale bot closed this as completed Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale Topic: Storybook Addon Issues and PRs for the official Storybook Addon Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: storybook-addon toolbar chakra-ui/chakra-ui
3 participants
@TimKolberger @guilleironhack @ngxCoder