Skip to content

Commit

Permalink
fix: not overwritable aria label prop on TagCloseButton (#5599)
Browse files Browse the repository at this point in the history
  • Loading branch information
m4x3d authored Feb 17, 2022
1 parent c2bcba1 commit 5d4abe4
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .changeset/yellow-baboons-hang.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@chakra-ui/tag": patch
---

Change order of aria-label prop on TagCloseButton to be overwritable
2 changes: 1 addition & 1 deletion packages/tag/src/tag.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,9 @@ export const TagCloseButton: React.FC<TagCloseButtonProps> = (props) => {

return (
<chakra.button
aria-label="close"
{...rest}
type="button"
aria-label="close"
disabled={isDisabled}
__css={btnStyles}
>
Expand Down

1 comment on commit 5d4abe4

@vercel
Copy link

@vercel vercel bot commented on 5d4abe4 Feb 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.