fix(extractor): never override node/ts #1096
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1008 (comment)
📝 Description
Fix node evaluation in extractor process (can happen when using a BinaryExpression, simple CallExpression or conditions)
Also updated
ts-morph
version to match the one fromtypescript
so there is no mismatch in theSyntaxKind
enum which can cause subtle issues such as the ones linked above💣 Is this a breaking change (Yes/No):
no
📝 Additional Information
we should probably never update
typescript
without updatingts-morph
as well