Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extractor): never override node/ts #1096

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

astahmer
Copy link
Collaborator

Closes #1008 (comment)

📝 Description

Fix node evaluation in extractor process (can happen when using a BinaryExpression, simple CallExpression or conditions)
Also updated ts-morph version to match the one from typescript so there is no mismatch in the SyntaxKind enum which can cause subtle issues such as the ones linked above

💣 Is this a breaking change (Yes/No):

no

📝 Additional Information

we should probably never update typescript without updating ts-morph as well

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023

🦋 Changeset detected

Latest commit: f5406c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 25 packages
Name Type
@pandacss/language-server Patch
@pandacss/extractor Patch
@pandacss/parser Patch
@pandacss/node Patch
panda-css-vscode Patch
@pandacss/types Patch
@pandacss/dev Patch
@pandacss/postcss Patch
@pandacss/studio Patch
@pandacss/astro Patch
@pandacss/config Patch
@pandacss/core Patch
@pandacss/error Patch
@pandacss/fixture Patch
@pandacss/generator Patch
@pandacss/is-valid-prop Patch
@pandacss/logger Patch
@pandacss/preset-atlaskit Patch
@pandacss/preset-base Patch
@pandacss/preset-panda Patch
@pandacss/shared Patch
@pandacss/token-dictionary Patch
@pandacss/extension-shared Patch
@pandacss/ts-plugin Patch
@pandacss/vsix-builder Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-docs ✅ Ready (Inspect) Visit Preview Jul 24, 2023 1:17pm
panda-playground ✅ Ready (Inspect) Visit Preview Jul 24, 2023 1:17pm
panda-studio ✅ Ready (Inspect) Visit Preview Jul 24, 2023 1:17pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AspectRatio still does not apply the ratio value
2 participants