fix: tokens for logical border widths#3238
Merged
segunadebayo merged 2 commits intoApr 24, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 11ba444 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Pull Request Overview
This PR introduces tokens for logical border widths and makes a minor change to the mergeProps implementation.
- Removed the MERGE_OMIT safeguard in the mergeProps helper.
- Added new tokens borderBlockStartWidth and borderBlockEndWidth in the border utility configuration.
- Included a changeset file documenting the change.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/studio/styled-system/helpers.mjs | Removed prototype/property filtering in mergeProps. |
| packages/preset-base/src/utilities/border.ts | Added logical border width tokens with a potential grouping issue. |
| .changeset/curly-waves-relate.md | Documented the addition of tokens for logical border widths. |
Comments suppressed due to low confidence (3)
packages/studio/styled-system/helpers.mjs:66
- Removal of the MERGE_OMIT variable may reintroduce prototype pollution risks by merging unsafe properties. Please confirm that this change is intentional and that such keys are handled elsewhere.
var MERGE_OMIT = /* @__PURE__ */ new Set(["__proto__", "constructor", "prototype"]);
packages/studio/styled-system/helpers.mjs:71
- The omission of the check for keys like proto, constructor, and prototype might lead to unintended side effects during property merging. Verify that this change aligns with intended behavior and security considerations.
if (MERGE_OMIT.has(key))
packages/preset-base/src/utilities/border.ts:170
- [nitpick] The tokens for borderBlockStartWidth and borderBlockEndWidth are using the group 'Border Radius', which might be a misclassification given they represent border widths. Consider updating the group name to 'Border' for consistency.
borderBlockStartWidth: { ... group: 'Border Radius', }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3237