Skip to content

fix: tokens for logical border widths#3238

Merged
segunadebayo merged 2 commits into
mainfrom
3237-logical-border-widths-are-not-getting-borderwidth-tokens
Apr 24, 2025
Merged

fix: tokens for logical border widths#3238
segunadebayo merged 2 commits into
mainfrom
3237-logical-border-widths-are-not-getting-borderwidth-tokens

Conversation

@anubra266
Copy link
Copy Markdown
Collaborator

@anubra266 anubra266 commented Apr 18, 2025

Fixes #3237

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 18, 2025

🦋 Changeset detected

Latest commit: 11ba444

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 20 packages
Name Type
@pandacss/preset-base Patch
@pandacss/config Patch
@pandacss/dev Patch
@pandacss/node Patch
@pandacss/parser Patch
@pandacss/studio Patch
@pandacss/astro-plugin-studio Patch
@pandacss/postcss Patch
@pandacss/core Patch
@pandacss/extractor Patch
@pandacss/generator Patch
@pandacss/is-valid-prop Patch
@pandacss/logger Patch
@pandacss/preset-atlaskit Patch
@pandacss/preset-open-props Patch
@pandacss/preset-panda Patch
@pandacss/reporter Patch
@pandacss/shared Patch
@pandacss/token-dictionary Patch
@pandacss/types Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
panda-docs ✅ Ready (Inspect) Visit Preview Apr 24, 2025 11:14am
panda-playground ✅ Ready (Inspect) Visit Preview Apr 24, 2025 11:14am
panda-studio ✅ Ready (Inspect) Visit Preview Apr 24, 2025 11:14am

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces tokens for logical border widths and makes a minor change to the mergeProps implementation.

  • Removed the MERGE_OMIT safeguard in the mergeProps helper.
  • Added new tokens borderBlockStartWidth and borderBlockEndWidth in the border utility configuration.
  • Included a changeset file documenting the change.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/studio/styled-system/helpers.mjs Removed prototype/property filtering in mergeProps.
packages/preset-base/src/utilities/border.ts Added logical border width tokens with a potential grouping issue.
.changeset/curly-waves-relate.md Documented the addition of tokens for logical border widths.
Comments suppressed due to low confidence (3)

packages/studio/styled-system/helpers.mjs:66

  • Removal of the MERGE_OMIT variable may reintroduce prototype pollution risks by merging unsafe properties. Please confirm that this change is intentional and that such keys are handled elsewhere.
var MERGE_OMIT = /* @__PURE__ */ new Set(["__proto__", "constructor", "prototype"]);

packages/studio/styled-system/helpers.mjs:71

  • The omission of the check for keys like proto, constructor, and prototype might lead to unintended side effects during property merging. Verify that this change aligns with intended behavior and security considerations.
if (MERGE_OMIT.has(key))

packages/preset-base/src/utilities/border.ts:170

  • [nitpick] The tokens for borderBlockStartWidth and borderBlockEndWidth are using the group 'Border Radius', which might be a misclassification given they represent border widths. Consider updating the group name to 'Border' for consistency.
borderBlockStartWidth: { ... group: 'Border Radius', }

@segunadebayo segunadebayo changed the title chore: tokens for logical border widths fix: tokens for logical border widths Apr 24, 2025
@segunadebayo segunadebayo merged commit 6fb83a8 into main Apr 24, 2025
5 of 7 checks passed
@segunadebayo segunadebayo deleted the 3237-logical-border-widths-are-not-getting-borderwidth-tokens branch April 24, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logical border widths are not getting borderWidth tokens

3 participants