Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TypeScript definition #32

Merged
merged 10 commits into from
Oct 4, 2019
Merged

Add TypeScript definition #32

merged 10 commits into from
Oct 4, 2019

Conversation

Akim95
Copy link
Contributor

@Akim95 Akim95 commented Oct 2, 2019

Feel free to contribute and keep it improving!

@sindresorhus
Copy link
Member

Thanks for creating a TypeScript definition. 🙌 Can you follow this styleguide?

Some examples:

@Akim95 Akim95 changed the title added TS typings Add TypeScript definition Oct 2, 2019
@sindresorhus
Copy link
Member

You need to wrap the options type in a namespace, see https://github.com/sindresorhus/typescript-definition-style-guide#documentation

index.d.ts Outdated Show resolved Hide resolved
@sindresorhus
Copy link
Member

You still need to do #32 (comment) and use tab-indentation.

@sindresorhus sindresorhus merged commit e77ea17 into chalk:master Oct 4, 2019
@sindresorhus
Copy link
Member

Thanks :)

@Akim95
Copy link
Contributor Author

Akim95 commented Oct 4, 2019

Welcome! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants