Move to class-based construction

[Qix-]

@sindresorhus right now, we use a traditional function/prototype build up of the Chalk class.

This has the negative side effect that in order to enable templating on custom contexts, you have to omit new - which is counterintuitive.

const ctx1 = chalk.constructor();
const ctx2 = new chalk.constructor();

const str1 = ctx1`hello`; // OK
const str2 = ctx2`hello`; // Error

Unless I'm mistaken, we can leverage constructor()'s ability to return a completely different object (even with new) to allow templates on all new chalk functions.

class Chalk {
    constructor(...) {
        // ... build up chalk template function ...
        return chalkTemplate;
    }

    // ...
}

const ctx = new Chalk();

const str = ctx`hello!`; // OK

Is this something we should do?

// cc @sindresorhus

tom-sherman earned $60.00 by resolving this issue!

• Checkout the Issuehunt explorer to discover more funded issues.
• Need some help from other developers? Add your repositories on Issuehunt to raise funds.

[sindresorhus]

Class syntax requires new though, so that would be a breaking change. We could do it and export a new method instead, maybe new Chalk.instance().

[Qix-]

True. Should util.deprecate the old function, too.

[wuweiweiwu]

@sindresorhus @Qix- I can take this! implement the new instance function

[sindresorhus]

@wuweiweiwu Sure, go ahead. Just make sure you run the benchmark so Chalk doesn't regress in performance.

[wuweiweiwu]

@sindresorhus I have a question. I was planning adding a new function chalk.template.instance. And have instance have a constructor so we can do new chalk.instance() and it would just return the template. Would that work?

[shaoron]

Let me complete this task

[wuweiweiwu]

@shaoron please do!

[IssueHuntBot]

@issuehuntfest has funded $60.00 to this issue. See it on IssueHunt

[IssueHuntBot]

@tom-sherman has submitted a pull request. See it on IssueHunt

[Qix-]

@IssueHuntBot don't care about seeing funding status - that's cool and all - but we can already see when people submit PRs. Don't need you to mirror that data, it just causes noise.

cc @Rokt33r

[sindresorhus]

@Qix- Agreed. Reported: https://spectrum.chat/issuehunt/?thread=e1907299-1270-4c35-af1c-51c53daf7aac

[IssueHuntBot]

@sindresorhus has rewarded $54.00 to @tom-sherman. See it on IssueHunt

• 💰 Total deposit: $60.00
• 🎉 Repository reward(0%): $0.00
• 🔧 Service fee(10%): $6.00