Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xml entity fixes #2778

Merged
merged 20 commits into from Feb 7, 2019

Conversation

Projects
None yet
5 participants
@AngelFQC
Copy link
Member

commented Jan 16, 2019

No description provided.

jmontoyaa and others added some commits Dec 21, 2018

@AngelFQC AngelFQC added this to the 1.11.10 milestone Jan 16, 2019

@AngelFQC

This comment has been minimized.

Copy link
Member Author

commented Jan 16, 2019

WIP

QTI imports xml, but is hard replace the current method to parse xml in qti import with Symfony's Crawler

@FlintCIBot

This comment has been minimized.

Copy link

commented Jan 16, 2019

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/16612

This comment was posted by FlintCI. It can be disabled in the repository settings.

AngelFQC added some commits Jan 18, 2019

Vendor - add ext-libxml
By recommendation of PhpStorm
@FlintCIBot

This comment has been minimized.

Copy link

commented Jan 18, 2019

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/16738

This comment was posted by FlintCI. It can be disabled in the repository settings.

@chamilo chamilo deleted a comment from codacy-bot Jan 18, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 18, 2019

AngelFQC added some commits Jan 21, 2019

Vendor - add ext-dom
By recomendation of PhpStorm
@FlintCIBot

This comment has been minimized.

Copy link

commented Jan 21, 2019

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/16961

This comment was posted by FlintCI. It can be disabled in the repository settings.

@chamilo chamilo deleted a comment from codacy-bot Jan 21, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 21, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 21, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 21, 2019

AngelFQC added some commits Jan 22, 2019

Remove functions with xml parser for qti1 import
Part of code removed from qti is using unset variables
Remove code about QTI1 import
See c109bae

Only support QTI2. Docs says it.
@FlintCIBot

This comment has been minimized.

Copy link

commented Jan 22, 2019

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/17020

This comment was posted by FlintCI. It can be disabled in the repository settings.

@chamilo chamilo deleted a comment from codacy-bot Jan 22, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 22, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 22, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 22, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 22, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 22, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 22, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 22, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 22, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 22, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 22, 2019

@chamilo chamilo deleted a comment from FlintCIBot Jan 23, 2019

@FlintCIBot

This comment has been minimized.

Copy link

commented Jan 23, 2019

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/17207

This comment was posted by FlintCI. It can be disabled in the repository settings.

@codacy-bot

This comment has been minimized.

Copy link

commented Jan 23, 2019

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 93
- Added 7
           

See the complete overview on Codacy

@chamilo chamilo deleted a comment from codacy-bot Jan 23, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 23, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 23, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 23, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 23, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 23, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 23, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 23, 2019

@chamilo chamilo deleted a comment from codacy-bot Jan 23, 2019

@AngelFQC

This comment has been minimized.

Copy link
Member Author

commented Jan 24, 2019

Import from QTI and Scorm done.

@ywarnier

This comment has been minimized.

Copy link
Member

commented Feb 7, 2019

Impressive.

@ywarnier ywarnier merged commit e55b5f5 into 1.11.x Feb 7, 2019

4 of 8 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
security/snyk - package.json (jmontoyaa) Manifest not found
Details
flintci/pr Lint errors found, a patch is available.
Details
flintci/push Lint errors found, a patch is available.
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer Analysis: 2 new issues, 2 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@AngelFQC AngelFQC deleted the xml_entity_fixes branch Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.