-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove vuex from some document components #5432
Remove vuex from some document components #5432
Conversation
* Set warning about using api.js
…mens # Conflicts: # assets/vue/components/documents/FormNewDocument.vue
getterType: "documents/getField", | ||
mutationType: "documents/updateField", | ||
}) | ||
|
||
export default { | ||
name: "DocumentsCreateFile", | ||
servicePrefix, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this line servicePrefix
? It's defined above const servicePrefix = "Documents"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, to be honest.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5432 +/- ##
=========================================
Coverage 40.21% 40.21%
Complexity 10328 10328
=========================================
Files 818 818
Lines 43434 43434
=========================================
Hits 17465 17465
Misses 25969 25969 ☔ View full report in Codecov by Sentry. |
Code Climate has analyzed commit fa2571a and detected 0 issues on this pull request. View more on Code Climate. |
Tested. Looks good. No change observed at the interface level. |
#5377