Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar fix for README.md #98

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@xorik
Copy link

xorik commented Mar 2, 2019

No description provided.

@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 2, 2019

Codecov Report

Merging #98 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #98   +/-   ##
======================================
  Coverage    83.6%   83.6%           
======================================
  Files           9       9           
  Lines         122     122           
  Branches       11      11           
======================================
  Hits          102     102           
  Misses         18      18           
  Partials        2       2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93cbca3...173a529. Read the comment docs.

@@ -59,7 +59,7 @@ npm install -D vuex-module-decorators
> **NOTE** Since version `0.9.3` we distribute as ES5, so this section is applicable only to v0.9.2 and below
This package generates code in `es2015` format. If your Vue project targets ES6 or ES2015 then
you need not do anything. But in case your project uses `es5` target (to support old browsers), then
you don't need to do anything. But in case your project uses `es5` target (to support old browsers), then

This comment has been minimized.

@FlorianWendelborn

FlorianWendelborn Mar 2, 2019

Contributor

While I think that the new proposal is easier to understand, the old sentence doesn’t seem to be invalid grammar: https://english.stackexchange.com/a/29413.

This comment has been minimized.

@xorik

xorik Mar 3, 2019

Author

Ok, feel free to close the PR :)

@xorik xorik closed this Mar 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.