Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working on Firefox 18 #62

Closed
Saqoosha opened this issue Jan 12, 2013 · 12 comments
Closed

Not working on Firefox 18 #62

Saqoosha opened this issue Jan 12, 2013 · 12 comments
Labels
bug

Comments

@Saqoosha
Copy link

@Saqoosha Saqoosha commented Jan 12, 2013

There is no error log in console.
ammo.js works same as on Firefox 17.

@chandlerprall

This comment has been minimized.

Copy link
Owner

@chandlerprall chandlerprall commented Jan 14, 2013

FF18 is the first version to have support for transferable objects, looks like the culprit lies therein. Should have this squared away within a few days.

@rileydutton

This comment has been minimized.

Copy link

@rileydutton rileydutton commented Jan 16, 2013

Just checking in on this, as it's affecting a project I'm working on as well.

@tapio

This comment has been minimized.

Copy link
Contributor

@tapio tapio commented Jan 16, 2013

As it affects me too, I attempted to fix it earlier, but failed. I bugged chandlerprall on IRC and he said he also had not yet managed a fix, but found at least "a couple FF bugs about TOs which indicate you may have to use ArrayBuffers instead of Float32Arrays".

@chandlerprall

This comment has been minimized.

Copy link
Owner

@chandlerprall chandlerprall commented Jan 16, 2013

I'm tempted to do UA detection as a temporary workaround. I should have some sort of solution, temporary or not, within the next 24 hours.

@chandlerprall

This comment has been minimized.

Copy link
Owner

@chandlerprall chandlerprall commented Jan 17, 2013

Fix is now up in the master branch, @tapio I took your updated version of physi.js as a starting point with the SUPPORT_TRANSFERABLE flag.

I don't think I'm seeing a speed impact but I'd be surprised if it isn't a couple FPS slower now -- overall any slowdowns are just Ammo.js being big. Cannot wait to get Physijs v2 into beta...

Very upset with Firefox at the moment...

[/tired rant]

Thank you @Saqoosha for reporting this, @tapio for helping look into the issue, and @rileydutton for using Physijs :)

@tapio

This comment has been minimized.

Copy link
Contributor

@tapio tapio commented Jan 17, 2013

Not seeing anything, forget to push?

@chandlerprall

This comment has been minimized.

Copy link
Owner

@chandlerprall chandlerprall commented Jan 17, 2013

Oh, would that help? ;)

Pushed - 4b54e78

@Saqoosha

This comment has been minimized.

Copy link
Author

@Saqoosha Saqoosha commented Jan 17, 2013

Great! It works with 18 now, but stop working with 17...

@rileydutton

This comment has been minimized.

Copy link

@rileydutton rileydutton commented Jan 17, 2013

Thanks! And you're welcome! :-)

@chandlerprall

This comment has been minimized.

Copy link
Owner

@chandlerprall chandlerprall commented Jan 18, 2013

Reopening to get FF<18 support back in

@chandlerprall chandlerprall reopened this Jan 18, 2013
@chandlerprall

This comment has been minimized.

Copy link
Owner

@chandlerprall chandlerprall commented Jan 19, 2013

@Saqoosha now working in FF<17, FF18, and verified still good in Chrome.

@Saqoosha

This comment has been minimized.

Copy link
Author

@Saqoosha Saqoosha commented Jan 21, 2013

@chandlerprall Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.