Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update TypeScript, ESLint, Babel and Jest dependencies #1012

merged 5 commits into from Nov 19, 2022


Copy link

@chaance chaance commented Nov 19, 2022

Just figured I'd do some housekeeping! Updating Jest results in some new snapshot formatting that required updates to those tests, though I checked the underlying assertions and they should be unchanged.

I updated TypeScript to 4.8 because ESLint's parser hasn't quite caught up to support 4.9 yet (it technically works fine, but I figured it's safer to just chill for a bit on that one).

I didn't include any Changesets here since I only touched dev dependencies. Let me know if you'd prefer to include one anyway.

A recent Jest update changed the way it formats snapshots. This commit updates
the snapshots to the new format without changing the tests themselves.
Copy link

changeset-bot bot commented Nov 19, 2022

⚠️ No Changeset found

Latest commit: 6b3b4a9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codesandbox-ci bot commented Nov 19, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6b3b4a9:

Sandbox Source
Vanilla Configuration

Copy link
Contributor Author

chaance commented Nov 19, 2022

It does look like CircleCI is running a Node 12 image which is incompatible with this change. Any harm in updating to 16 since we're well beyond EOL for 12?

@chaance chaance force-pushed the chance/update-build-dev-tools branch from 42d850b to 6b3b4a9 Compare November 19, 2022 16:23
@Andarist Andarist merged commit e0459f7 into changesets:main Nov 19, 2022
4 checks passed
Copy link

It does look like CircleCI is running a Node 12 image which is incompatible with this change. Any harm in updating to 16 since we're well beyond EOL for 12?

I think it's fine. The supported node version for Changesets is not well-defined (our mistake but at the moment it's hard to know the node requirements of our whole dependency graph).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants