Cleanup @changesets/git tests
#1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| Name | Type |
|---|---|
| @changesets/git | Major |
| @changesets/apply-release-plan | Patch |
| @changesets/cli | Patch |
| @changesets/read | Patch |
| @changesets/release-utils | Patch |
| @changesets/get-release-plan | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit adf66bd:
|
Andarist
force-pushed
the
cleanup-git-pkg-tests
branch
from
71bbe7a
to
9a19bcc
Compare
emmatown
reviewed
Dec 13, 2022
chaance
requested changes
Dec 13, 2022
| */ | ||
| export async function getCommitsThatAddFiles( | ||
| gitPaths: string[], | ||
| cwd: string | ||
| { cwd, short = false }: { cwd: string; short?: boolean } |
There was a problem hiding this comment.
Since this is exposed API, should we include a changeset to document it?
There was a problem hiding this comment.
Yeap, gonna add changesets before merging this - a few minor breaking changes got included here as part of the refactor.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR:
beforeEachhooks in favor of explicit setup per testgetCurrentCommitIdTODO:
@changesets/gitpackage since the second change could be seen as a breaking change