Fix return value of getCurrentCommitId
#889
Conversation
🦋 Changeset detectedLatest commit: 3acf4bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3acf4bc:
|
packages/git/src/index.ts
Outdated
| @@ -296,5 +296,6 @@ export async function getCurrentCommitId({ | |||
| await spawn("git", ["show", `--format="%h"`, "--no-patch"], { cwd }) | |||
| ).stdout | |||
| .toString() | |||
| .trim(); | |||
| .trim() | |||
| .replace(/"/g, ""); | |||
There was a problem hiding this comment.
Interesting, git show --format="%h" --no-patch doesnt add quotation marks in the stdout for me. What system and git version are you using?
There was a problem hiding this comment.
Windows 10 Enterprise 21H1, git 2.30.1.windows.1.
When i run git show --format="%h" --no-patch in PowerShell, I also see only the hash 🤔
packages/git/src/index.ts
Outdated
| @@ -296,5 +296,6 @@ export async function getCurrentCommitId({ | |||
| await spawn("git", ["show", `--format="%h"`, "--no-patch"], { cwd }) | |||
There was a problem hiding this comment.
I wonder if the reason we end up with those quotation marks isn't that we include them here in the format. I've checked on my machine and this works fine too:
| await spawn("git", ["show", `--format="%h"`, "--no-patch"], { cwd }) | |
| await spawn("git", ["show", "--format=%h", "--no-patch"], { cwd }) |
Alternatively we could also just switch to using this:
| await spawn("git", ["show", `--format="%h"`, "--no-patch"], { cwd }) | |
| await spawn("git", ["rev-parse", "--short", "HEAD"], { cwd }) |
It seems to be better suited for this job anyway.
There was a problem hiding this comment.
Both suggestion seem to solve the problem. I agree that the second one seems to be better for this. I updated the PR.
fixes #888