Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

PHPDoc / Types fixes #82

Merged
merged 1 commit into from Apr 11, 2013

Conversation

Projects
None yet
4 participants
Contributor

adrienbrault commented Apr 9, 2013

No description provided.

Owner

chanmix51 commented Apr 9, 2013

It is really the convention not to provide FQCN in the PHPDoc blocks ?

sstok commented Apr 11, 2013

Its cleaner to use imported short versions, and it also saves some bytes ;)

This @param Pomm\Tools\Logger $logger is troubling as most IDE's see this as relative to the current namespace. When using this it should always start with \ to indicate its not relative.

Contributor

jeremyFreeAgent commented Apr 11, 2013

Good to know! 👍

Owner

chanmix51 commented Apr 11, 2013

Right ... good point @sstok this means it fixes something + makes the code better.

it's ok to me then.

@chanmix51 chanmix51 added a commit that referenced this pull request Apr 11, 2013

@chanmix51 chanmix51 Merge pull request #82 from adrienbrault/fixes
PHPDoc / Types fixes
375350e

@chanmix51 chanmix51 merged commit 375350e into chanmix51:master Apr 11, 2013

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment