feat(lib-storage): verify uploaded parts when resuming #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfoo1984
commented
Mar 31, 2022
Comment on lines
-32
to
-34
| ChecksumCRC32?: string; | ||
| ChecksumCRC32C?: string; | ||
| ChecksumSHA1?: string; |
There was a problem hiding this comment.
Since we're not currently supporting or using these checksum options, I thought it'd be better just to remove them here and below, to minimize changes to this forked lib and potential confusion or errors.
irene-han
approved these changes
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Shortcut Ticket
Description
Notes
x-amz-checksum-sha256header needs to be exposed in CORS config for bucket to be able to receive SHA-256 checksum from AWS. This was configured in our terraform repo: chanzuckerberg/idseq-infra#587.Testing
Manually tested in CZ ID web app
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.