Refactor developer convenience scripts #1377
Conversation
frontend_dev is a soup-to-nuts convenience method for setting up the FE development environment with node running a the client code on port 3000 with the a separate cellxgene package serving the API over port 5005 in the background. The script can be run from Finder.
Codecov Report
@@ Coverage Diff @@
## master #1377 +/- ##
=======================================
Coverage 62.32% 62.32%
=======================================
Files 68 68
Lines 5274 5274
Branches 377 377
=======================================
Hits 3287 3287
Misses 1895 1895
Partials 92 92
Continue to review full report at Codecov.
|
mweiden
force-pushed
the
mweiden/fe-dev-automation
branch
from
223fac4
to
f50e5e0
Compare
Rationale: * Given how long the smoke tests take to run, it is unlikely that developers will want to run all tests together. * It is unlikely that developers will have set up the backend server properly for the tests to pass. * Available commands should be safe-ish and not lend themselves to confusing errors. * You can still group tests by concatenating them in a make command, as in `make unit-test smoke-test`. * This target isn't used in any of our CI pipelines -- KISS.
mweiden
force-pushed
the
mweiden/fe-dev-automation
branch
from
f50e5e0
to
422eb40
Compare
There was a problem hiding this comment.
I like it. I'm not really the target audience though. If @seve and @colinmegill are good, you might also want to run it by @liaprins-czi
mweiden
force-pushed
the
mweiden/fe-dev-automation
branch
from
adca916
to
b7cf113
Compare
mweiden
force-pushed
the
mweiden/fe-dev-automation
branch
from
b7cf113
to
25126c9
Compare
|
Is there a way to set a |
|
@seve I don't know of a way to generalize that yet, but will give it some thought and follow up with a second PR if I can find a solution. What terminal are you using? iTerm2? |
I'm using Hyper(https://hyper.is/) |
|
Hmmm, OK. Thinking. |
backend-devtarget inclient/Makefileto its own script (scripts/backend_dev), thereby better decoupling theclient/from build targets elsewhere in the repotesttarget, this doesn't have much practical use anymorebackend-dev-anno-ontologytarget. Turning this on through the convenience scripts is still possible withCXG_OPTIONS, which you had to do anyway to run it throughbackend-devscripts/frontend_devconvenience method, which opens up Terminal, starts the cellxgene in one tab on port5005, and the node dev server on port3000for hot-reloading development