Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should chaos mesh support modifying chaos spec? #2227

Open
fewdan opened this issue Aug 17, 2021 · 3 comments
Open

Should chaos mesh support modifying chaos spec? #2227

fewdan opened this issue Aug 17, 2021 · 3 comments
Assignees
Labels

Comments

@fewdan
Copy link
Member

fewdan commented Aug 17, 2021

Feature Request

Is your feature request related to a problem? Please describe:

Because of #1905 , the current chaos mesh does not support modifying the chaos spec.

Describe the feature you'd like:

I think it is necessary to modify the spec when running chaos. But will this cause any problems?

@YangKeao Any good ideas?

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

@fewdan fewdan added the type/enhancement New feature or request label Aug 17, 2021
@cwen0 cwen0 added this to To do in Project Kanban via automation Aug 17, 2021
@g1eny0ung
Copy link
Member

g1eny0ung commented Aug 20, 2021

After our @chaos-mesh/maintainers @chaos-mesh/committers discussion, TL;DR, even though we used to support this feature, we have decided not to support it for now.

In general, the scope of allowed changes is not well defined. Should we allow users to change all the configuration items? Obviously not, if you update the name of chaos, you create new chaos, or if we change the action of a NetworkChaos, it will be completely different chaos!

At the same time, to meet the limited scope updates, we need to extend our validation, which will increase the complexity of the code to some extent. While this is not impossible to do, it is not the solution we expect, it is like patching all the time. In the future, we are bound to introduce new chaos, and then we have to continue patching again. 😵

So, in the case that we can't clearly grasp the behavior generated by the definition, we will discuss this feature for the time being. If in the future we find a better solution or a strong user need arises, we will continue to revisit this issue.

@g1eny0ung g1eny0ung moved this from To do to Backlog in Project Kanban Aug 20, 2021
@mladedav
Copy link

mladedav commented Sep 9, 2021

And if there is a need or we want to test different values of chaos spec, what is the preferred solution? Create multiple chaos specs and pause/resume them? Delete old specs and create new ones?

@fewdan
Copy link
Member Author

fewdan commented Sep 13, 2021

And if there is a need or we want to test different values of chaos spec, what is the preferred solution? Create multiple chaos specs and pause/resume them? Delete old specs and create new ones?

Yes, I think the current plan is: create chaos with different specs, and compare these chaos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants