Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add monitoring metrics about Chaos Mesh #2397

Closed
15 tasks done
TangliziGit opened this issue Oct 19, 2021 · 0 comments
Closed
15 tasks done

Add monitoring metrics about Chaos Mesh #2397

TangliziGit opened this issue Oct 19, 2021 · 0 comments

Comments

@TangliziGit
Copy link
Contributor

TangliziGit commented Oct 19, 2021 •
edited
Loading

Feature Request

Is your feature request related to a problem? Please describe:

More metrics are needed for improving the observability of chaos-controller-manager, chaos-daemon, and chaos-dashboard. Now, we already have several metrics in chaos-controller-manager and chaos-daemon, but it's not enough.

Describe the feature you'd like:

There is an RFC describing the feature in detail: chaos-mesh/rfcs#23
Below is a list of metrics which needs to be implemented:

Describe alternatives you've considered:

No.

Teachability, Documentation, Adoption, Migration Strategy:

These metrics will be exposed on /metrics HTTP endpoint which Prometheus can collect. Users should use these metrics to make dashboards through G to show the operation of the system.
TangliziGit added a commit to TangliziGit/chaos-mesh that referenced this issue Oct 19, 2021
@TangliziGit
feat(pkg/metrics): add schedule, workflow, and event gauge metrics
2934b68 
1. In order to put all the component metrics collection code in the same package,
 move the `controllers/metrics` package to `pkg/metrics`.
2. add `chaos_controller_manager_chaos_schedule_count`,
 `chaos_controller_manager_chaos_workflow_count`, and
 `chaos_controller_manager_emitted_event_count` metrics.
3. rename `chaos_experiment_status` into
 `chaos_controller_manager_chaos_experiments_count`.

issue: chaos-mesh#2397

Signed-off-by: TangliziGit <tanglizimail@foxmail.com>
TangliziGit added a commit to TangliziGit/chaos-mesh that referenced this issue Oct 19, 2021
@TangliziGit
feat(pkg/metrics): add schedule, workflow, and event gauge metrics
9d59f0e 
1. In order to put all the component metrics collection code in the same package,
 move the `controllers/metrics` package to `pkg/metrics`.
2. add `chaos_controller_manager_chaos_schedule_count`,
 `chaos_controller_manager_chaos_workflow_count`, and
 `chaos_controller_manager_emitted_event_count` metrics.
3. rename `chaos_experiment_status` into
 `chaos_controller_manager_chaos_experiments_count`.

issue: chaos-mesh#2397

Signed-off-by: TangliziGit <tanglizimail@foxmail.com>
TangliziGit added a commit to TangliziGit/chaos-mesh that referenced this issue Oct 19, 2021
@TangliziGit
feat(pkg/metrics): add schedule, workflow, and event gauge metrics
bdf0756 
1. In order to put all the component metrics collection code in the same package,
 move the `controllers/metrics` package to `pkg/metrics`.
2. add `chaos_controller_manager_chaos_schedule_count`,
 `chaos_controller_manager_chaos_workflow_count`, and
 `chaos_controller_manager_emitted_event_count` metrics.
3. rename `chaos_experiment_status` into
 `chaos_controller_manager_chaos_experiments_count`.

issue: chaos-mesh#2397

Signed-off-by: TangliziGit <tanglizimail@foxmail.com>
TangliziGit added a commit to TangliziGit/chaos-mesh that referenced this issue Oct 19, 2021
@TangliziGit
feat(pkg/metrics): add schedule, workflow, and event gauge metrics
3d72ab4 
1. In order to put all the component metrics collection code in the same package,
 move the `controllers/metrics` package to `pkg/metrics`.
2. add `chaos_controller_manager_chaos_schedule_count`,
 `chaos_controller_manager_chaos_workflow_count`, and
 `chaos_controller_manager_emitted_event_count` metrics.
3. rename `chaos_experiment_status` into
 `chaos_controller_manager_chaos_experiments_count`.

issue: chaos-mesh#2397

Signed-off-by: TangliziGit <tanglizimail@foxmail.com>
@TangliziGit TangliziGit mentioned this issue Oct 19, 2021
Merged
5 tasks
This was referenced Oct 29, 2021
Merged
Merged
ti-chi-bot added a commit that referenced this issue Nov 4, 2021
@TangliziGit @ti-chi-bot
feat(metrics): add schedule and workflow metrics (#2402)
c0f3dec 
* feat(pkg/metrics): add schedule, workflow, and event gauge metrics

1. In order to put all the component metrics collection code in the same package,
 move the `controllers/metrics` package to `pkg/metrics`.
2. add `chaos_controller_manager_chaos_schedule_count`,
 `chaos_controller_manager_chaos_workflow_count`, and
 `chaos_controller_manager_emitted_event_count` metrics.
3. rename `chaos_experiment_status` into
 `chaos_controller_manager_chaos_experiments_count`.

issue: #2397

Signed-off-by: TangliziGit <tanglizimail@foxmail.com>

* fix: remove name suffix `count` for Gauge and update their messages

Signed-off-by: TangliziGit <tanglizimail@foxmail.com>

* fix: remove `count` suffix for Guage and avoid using `reflect` to collect metrics

Signed-off-by: TangliziGit <tanglizimail@foxmail.com>

Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
@TangliziGit TangliziGit mentioned this issue Nov 9, 2021
Merged
8 tasks
This was referenced Nov 18, 2021
Merged
Merged
@TangliziGit TangliziGit mentioned this issue Nov 27, 2021
Merged
8 tasks
@STRRL STRRL mentioned this issue Jan 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TangliziGit