Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove privileged and add some capabilities #1109

Merged
merged 12 commits into from
Nov 2, 2020
Merged

Remove privileged and add some capabilities #1109

merged 12 commits into from
Nov 2, 2020

Conversation

YangKeao
Copy link
Member

What problem does this PR solve?

Fix #1101

What is changed and how does it work?

Chaos Daemon now works with privileged: false. In replace, it creates a fuse device and add it to cgroup device list manually.

@YangKeao
remove privileged
677f53c 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
remove privileged
ca530e8 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
add device to cgroup list
34dfe9c 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
Merge remote-tracking branch 'upstream/master' into remove-privileged
3e683ac
@YangKeao
restore e2e.go
2f3b35a 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
add some comments
5e0cdc0 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@codecov-io
Copy link

codecov-io commented Oct 28, 2020 •
edited
Loading

Codecov Report

Merging #1109 into master will decrease coverage by 7.89%.
The diff coverage is 26.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1109      +/-   ##
==========================================
- Coverage   55.78%   47.89%   -7.90%     
==========================================
  Files          68       72       +4     
  Lines        4383     4320      -63     
==========================================
- Hits         2445     2069     -376     
- Misses       1768     2042     +274     
- Partials      170      209      +39
Impacted Files Coverage Δ
api/v1alpha1/common_types.go 0.00% <0.00%> (ø)
api/v1alpha1/common_validation.go 100.00% <ø> (ø)
api/v1alpha1/common_webhook.go 100.00% <ø> (ø)
api/v1alpha1/dnschaos_type.go 0.00% <0.00%> (ø)
api/v1alpha1/dnschaos_webhook.go 0.00% <0.00%> (ø)
api/v1alpha1/httpchaos_types.go 0.00% <0.00%> (ø)
api/v1alpha1/iochaos_types.go 0.00% <ø> (-40.00%) ⬇️
api/v1alpha1/kernelchaos_types.go 0.00% <ø> (-20.00%) ⬇️
api/v1alpha1/kernelchaos_webhook.go 100.00% <ø> (+14.81%) ⬆️
api/v1alpha1/kinds.go 27.27% <ø> (+0.60%) ⬆️
... and 107 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d206df...333d573. Read the comment docs.

@YangKeao
Copy link
Member Author

/run-e2e-tests

@YangKeao
update install.sh
287cd62 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
Copy link
Member Author

/run-e2e-tests

@YangKeao
remove privileged
10bf801 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
Copy link
Member Author

/run-e2e-tests

@YangKeao YangKeao changed the title Remove privileged and add a lot of capabilities Remove privileged and add some capabilities Oct 28, 2020
@YangKeao
update install.sh
0f06b80 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
Copy link
Member Author

/run-e2e-tests

@YangKeao
add CAP_IPC_LOCK
2d06fb7 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
Copy link
Member Author

/run-e2e-tests

@YangKeao
remove cap ahead
4008653 
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
Copy link
Member Author

/run-e2e-tests

cwen0
cwen0 approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

WangXiangUSTC
WangXiangUSTC approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fewdan
Copy link
Member

fewdan commented Oct 30, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@cwen0 cwen0 merged commit 4afe61f into chaos-mesh:master Nov 2, 2020
@ti-srebot ti-srebot mentioned this pull request Nov 2, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-1.0 in PR #1126

cwen0 pushed a commit that referenced this pull request Nov 2, 2020
@ti-srebot
Remove privileged and add some capabilities (#1109) (#1126)
d8ab250
@YangKeao YangKeao mentioned this pull request Nov 2, 2020
Closed
@WangXiangUSTC WangXiangUSTC mentioned this pull request Nov 10, 2020
Closed
5 tasks
@YangKeao YangKeao mentioned this pull request Dec 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

@cwen0 cwen0 cwen0 approved these changes

Assignees
No one assigned
Labels
status/can-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chaos daemon run with privileged = false
6 participants
@YangKeao @codecov-io @fewdan @ti-srebot @WangXiangUSTC @cwen0