Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Controller for awsssmchaosrunner #1919

Closed
wants to merge 4 commits into from
Closed

Added Controller for awsssmchaosrunner #1919

wants to merge 4 commits into from

Conversation

Debanitrkl
Copy link
Contributor

What problem does this PR solve?

This is a controller for the integration of awsssmchaosrunner with chaos mesh according to this rfc.

What is changed and how does it work?

Added a file under controllers/awschaos called attack-configuration

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?

Yes a new feature under `awschaos` is added

STRRL and others added 2 commits April 17, 2021 19:01
@STRRL @ti-chi-bot @Debanitrkl
chaos-dashboard web api for workflow (chaos-mesh#1583)
ff58c43 
* feat: workflow basic CRD and concilers

Signed-off-by: STRRL <str_ruiling@outlook.com>

* refactor(workflow): refine codes about determine conditions

Signed-off-by: STRRL <str_ruiling@outlook.com>

* feat: the chaos node reconciler

Signed-off-by: STRRL <str_ruiling@outlook.com>

* feat: add shor name for workflow and workflow node

Signed-off-by: STRRL <str_ruiling@outlook.com>

* feat: events to describe creating chaos CR

Signed-off-by: STRRL <str_ruiling@outlook.com>

* feat: add state for chaos cr created

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: tidy go.sum

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: preload go mod

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: partial updates

Signed-off-by: STRRL <str_ruiling@outlook.com>

* docs: update design docs

Signed-off-by: STRRL <str_ruiling@outlook.com>

* feat: recover for chaos nodes

Signed-off-by: STRRL <str_ruiling@outlook.com>

* docs: update the docs

Signed-off-by: STRRL <str_ruiling@outlook.com>

* feat: update the optioanl fields

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: update after make check

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: remove unused fields

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: fix the comments

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: fix typos

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: update the yaml

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: address the comments

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: reconstruct method orders

Signed-off-by: STRRL <str_ruiling@outlook.com>

* feat: implmenetation of web api

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: make linters happy

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: address the comments

Signed-off-by: STRRL <str_ruiling@outlook.com>

* feat: register workflow controller into fx

Signed-off-by: STRRL <str_ruiling@outlook.com>

* feat: use empty slice instead of nil

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: cleanup unused states

Signed-off-by: STRRL <str_ruiling@outlook.com>

* refactor: determine running nodes out of the conversion funcs

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: remove the meaningless if

Signed-off-by: STRRL <str_ruiling@outlook.com>

* fix: update the entity used in swagger

Signed-off-by: STRRL <str_ruiling@outlook.com>

* fix: fix bugs with conversion workflow detail

Signed-off-by: STRRL <str_ruiling@outlook.com>

* feat: determine node state

Signed-off-by: STRRL <str_ruiling@outlook.com>

* fix: do not apply networkchaos if condition injected is true

Signed-off-by: STRRL <str_ruiling@outlook.com>

* refactor: do not use the ambiguous name while in retry closures

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: update the workflow example

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: fmt the codes

Signed-off-by: STRRL <str_ruiling@outlook.com>

* refactor: conversation enitity and fix test cases

Signed-off-by: STRRL <str_ruiling@outlook.com>

* feat: use clientpool instead of embedded kubeclient

maybe we could use factory in the future

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: make linter happy

Signed-off-by: STRRL <str_ruiling@outlook.com>

* feat: remove the current nodes in workflow detail

Signed-off-by: STRRL <str_ruiling@outlook.com>

* feat: hTTP API create and update of workflow

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: address the comments of muse-dev

Signed-off-by: STRRL <str_ruiling@outlook.com>

* fix: address the comments

Signed-off-by: STRRL <str_ruiling@outlook.com>

* chore: make linters happy

Signed-off-by: STRRL <str_ruiling@outlook.com>

Co-authored-by: Ti Chi Robot <71242396+ti-chi-bot@users.noreply.github.com>
Signed-off-by: Debanitrkl <118BM0622@nitrkl.ac.in>
@Debanitrkl
Added controller for awsssmchaosrunner under awschaos
e947feb 
Signed-off-by: Debanitrkl <118BM0622@nitrkl.ac.in>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested review from cwen0 and Hexilee June 2, 2021 03:20
STRRL
STRRL reviewed Jun 4, 2021
View reviewed changes
controllers/awschaos/attack-configuration/types.go
},
},
}
e.Log.Info("Running the Container")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After creating the Pod, you should update the status of AwsChaos. It means you should also create new fields to describe the status of that created Pod.

And that status will be also used when Recover().

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah working on that

@ti-chi-bot
Copy link
Member

@Debanitrkl: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@STRRL
Copy link
Member

STRRL commented Aug 13, 2021

I am going to close this PR because it seems not to be updated

@STRRL STRRL closed this Aug 13, 2021
@Debanitrkl
Copy link
Contributor Author

Can we put this in WIP I'm on a break and I will get back to this as soon as possible.
Sorry for the delay got caught up with lot of work in last two months.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@STRRL STRRL STRRL left review comments

@cwen0 cwen0 Awaiting requested review from cwen0

@Hexilee Hexilee Awaiting requested review from Hexilee

Assignees
No one assigned
Labels
contribution do-not-merge/work-in-progress needs-rebase size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Debanitrkl @ti-chi-bot @STRRL