Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New implementation of IoChaos #826

Merged
merged 74 commits into from
Sep 21, 2020
Merged

New implementation of IoChaos #826

merged 74 commits into from
Sep 21, 2020

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Aug 20, 2020

What problem does this PR solve?

This PR submits a new implementation of IoChaos. With this implementation, there is no need to inject a sidecar container, so that it's easier to use.

Note:

  • The toda directory is managed with git submodules

  • Keep in mind that all information (such as attributes, content) could be stored in the page cache.

  • The definition of IoChaos has changed, so the dashboard needs to be modified. (I have tried to make this modification minimal)

Known issues:

  • If you delete the chaos-daemon while injecting, the target pod may panic.

TODO:

  • Resolve the deadlock in toda

  • Add e2e test.

  • Add more examples.

  • Support mmap

  • Change current directory

  • Fix Dockerfile for building UI and swagger

  • Auto resolve soft link (to volume mount path)

What is changed and how does it work?

Checklist

Tests

  • Manual test

@YangKeao YangKeao requested a review from cwen0 August 20, 2020 07:14
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2020

Codecov Report

Merging #826 into master will decrease coverage by 5.19%.
The diff coverage is 37.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
- Coverage   55.78%   50.59%   -5.20%     
==========================================
  Files          68       67       -1     
  Lines        4383     4319      -64     
==========================================
- Hits         2445     2185     -260     
- Misses       1768     1936     +168     
- Partials      170      198      +28     
Impacted Files Coverage Δ
api/v1alpha1/common_validation.go 100.00% <ø> (ø)
api/v1alpha1/common_webhook.go 100.00% <ø> (ø)
api/v1alpha1/iochaos_types.go 39.43% <0.00%> (-0.57%) ⬇️
api/v1alpha1/kernelchaos_types.go 19.71% <0.00%> (-0.29%) ⬇️
api/v1alpha1/kernelchaos_webhook.go 85.18% <ø> (ø)
api/v1alpha1/kinds.go 26.66% <ø> (ø)
api/v1alpha1/networkchaos_types.go 22.83% <0.00%> (-0.15%) ⬇️
api/v1alpha1/podchaos_types.go 36.61% <0.00%> (-0.53%) ⬇️
api/v1alpha1/podchaos_webhook.go 81.96% <ø> (ø)
api/v1alpha1/podiochaos_webhook.go 0.00% <0.00%> (ø)
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f0d4a6...8fc9688. Read the comment docs.

Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
Copy link
Member Author

/run-e2e-tests

YangKeao and others added 3 commits September 16, 2020 14:06
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
@YangKeao
Copy link
Member Author

/run-e2e-tests

cwen0 and others added 2 commits September 16, 2020 20:00
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao
Copy link
Member Author

/run-e2e-tests

@YangKeao
Copy link
Member Author

/run-e2e-tests

cwen0
cwen0 previously approved these changes Sep 21, 2020
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member Author

/run-e2e-tests

Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fewdan
Copy link
Member

fewdan commented Sep 21, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 8581cd0 into chaos-mesh:master Sep 21, 2020
@ti-srebot
Copy link
Contributor

cherry pick to release-1.0 failed

YangKeao added a commit to YangKeao/chaos-mesh that referenced this pull request Sep 21, 2020
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
YangKeao added a commit that referenced this pull request Sep 21, 2020
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants