Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Clone in Desktop Download ZIP

Loading…

use <sys/xattr.h> rather than <attr/xattr.h> #14

Closed
wants to merge 1 commit into from

2 participants

@pipcet

This is a bit tentative, since I don't have a Red Hat system to compare right now:

On my Debian system, doesn't exist. does, and provides the right prototypes for xattr.c to use, apparently, so this tiny change makes things compile on an up-to-date sid system.

Mostly, though, this is a success report: with a few trivial changes (to work around the constrained environment of the Debian initrd), I'm able to boot a diskless IPv6-only virtual machine with its (post-initrd) root file system served by diod!

@garlick
Owner

Thanks for your PR. I think it needs to be an autoconf test rather than the direct change though, as I think the old way still is correct on Ubuntu 14.04, RHEL 6, and if it was wrong on RHEL 7 I didn't notice it. I don't mind doing that though, so no need to resubmit the PR.

Glad to hear you've got diskless working! How's the performance and what mount options are you using? Think you might like to work up a wiki howto on it?

@pipcet

Oh, I'm sorry! I was looking for , which isn't in any Debian package, rather than the correct , which is in libattr1-dev. It works with that package installed, so no Debian special case is necessary.

Sorry for the wasted time.

@pipcet pipcet closed this
@pipcet pipcet deleted the pipcet:xattr-xattr-h branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  diod/xattr.c
View
2  diod/xattr.c
@@ -39,7 +39,7 @@
#include <errno.h>
#include <sys/types.h>
#include <sys/file.h>
-#include <attr/xattr.h>
+#include <sys/xattr.h>
#include <sys/stat.h>
#include <sys/statfs.h>
#include <sys/socket.h>
Something went wrong with that request. Please try again.