[servers/console] Add new activation flag #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perlun
force-pushed
the
fix/console-server-activate-cluido-only
branch
from
3dadbb0
to
e69b222
Compare
perlun
changed the title
This flag is to be used by cludio, and by cluido only, to ensure that the cluido console is always made visible when created; other servers have a lower pirority. This is important to give the user a decent experience when running e.g. the chaos Docker container, using a pre-compiled chaos .iso image etc. Closes #45; there are still some issues with the kernel log console (as being created by the log server) not being visible, but I will create a separate issue for that before merging this one.
Instead of taking 5 parameters specicying the requested video mode, provide a ipc_console_attribute_type parameter right away.
perlun
force-pushed
the
fix/console-server-activate-cluido-only
branch
from
2f51853
to
168bffc
Compare
perlun
commented
Nov 10, 2018
|
|
||
| // Indicates that the console should be activated upon creation. Can only be done once; if | ||
| // there is already an active console, this flag will be ignored by the console server. | ||
| bool activate; |
There was a problem hiding this comment.
This is the new flag being added.
perlun
added a commit
that referenced
this pull request
Jul 1, 2019
Also adjusted the call to `console_open` to be compatible with the changes introduced in #137.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is to be used by cluido, and by cluido only, to ensure that the cluido console is always made visible when created; other servers have a lower priority. This is important to give the user a decent
experience when running e.g. the chaos Docker container, using a pre-compiled chaos .iso image etc.
Closes #45; there are still some issues with the kernel log console (as being created by the log server) not being visible, but I will create a separate issue for that before merging this one.