Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate Release Comments (Format and Presentation) #182

Closed
klumb opened this issue Jun 22, 2019 · 14 comments

Comments

@klumb
Copy link
Member

commented Jun 22, 2019

This issue was created to collect comments about the upcoming metrics release.

This thread is for comments about the webpage and presentation of the metrics. To make comments about the focus areas and individual metrics, please follow the links in the release tables.

https://chaoss.community/metrics-rc/

Important Dates

Release Freeze: June 21st, 2019
Candidate Release: June 24th, 2019
Comments Close: July 24th, 2019
Release Date: August 1st, 2019

@geekygirldawn

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

I love the overall look! I didn't check all of the links, but I did notice that the link to the "Code of Conduct at Event" metric from the D&I Event Diversity Focus Area is currently 404.

@klumb

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

@GeorgLink

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

I edited the "Release Table", renaming it.
I just checked all the links.

Tasks I see remaining:

  • fix realtive paths in Evolution metrics for the screenshots
  • insert Risk metrics and create issues for comments
  • add a section for the Value WG that links to the repo, like all other areas, but without metrics
@klumb

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

I think the relative path issue is something the working groups should resolve. Perhaps we can talk about that in the community meeting on June 25th.

As @geekygirldawn said, relative paths are generally seen as best practice but seeing as these detail pages are being created for release outside of GitHub, I think it is fair to ask that for these pages only, images and links use absolute paths.

@klumb

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2019

The tables are not mobile friendly. I am working on a fix.

@klumb

This comment has been minimized.

Copy link
Member Author

commented Jul 7, 2019

I have implemented a fix to make the tables dynamic and allow for scrolling on smaller mobile devices. @GeorgLink and @geekygirldawn, please review

@GeorgLink

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Thank you @klumb the mobile version is better.

Here is another idea: how about reducing the padding in the table on mobile?

  • smaller font
  • force line break
@germonprez

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

I tried small font but HTML in MD is weird.

@GeorgLink

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Yes. Doing it in markdown is not working well due to the import to WordPress.
@klumb is experimenting with CSS formatting in Wordpress - this is delivering the results we want.

@germonprez

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Ah!

@klumb

This comment has been minimized.

Copy link
Member Author

commented Jul 8, 2019

Okay, I have made a few adjustments to column width, line-height, padding, and font size. The tables are pretty dynamic based on device size now.

The addition of the comment links on the detail pages makes the table comment link a little redundant so on small mobile devices, I have set the last column to disappear. I think it enhances the mobile presentation. Please let me know your thoughts.

@GeorgLink

This comment has been minimized.

Copy link
Member

commented Jul 8, 2019

Excellent! Thank you very much @klumb

I agree with disappearing the last column on small screens!

@germonprez

This comment has been minimized.

Copy link
Contributor

commented Jul 8, 2019

Thanks @klumb

@geekygirldawn

This comment has been minimized.

Copy link
Member

commented Aug 15, 2019

It looks like this is done, so I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.