Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate Release Comments (Review Duration) #189

GeorgLink opened this issue Jun 22, 2019 · 2 comments


None yet
3 participants
Copy link

commented Jun 22, 2019

This issue was created to collect comments about the upcoming metrics release.

This thread is for comments about Review Duration

GitHub location:

Release candidate:

See all release candidates of metrics are at:

Important Dates

Release Freeze: June 21st, 2019
Candidate Release: June 24th, 2019
Comments Close: July 24th, 2019
Release Date: August 1st, 2019


This comment has been minimized.

Copy link

commented Jul 3, 2019

The structural definition of this metric looks good to me. The only issue that may arise with any kind of computation that captures duration, is the time between no activity. For example, consider an ongoing review process, and suppose there is a time slot let's say two months in between the review process were there is no activity, should we still count this two months period as review time?


This comment has been minimized.

Copy link

commented Jul 9, 2019

Thanks for the comment. The idea here is to capture the time since the review starts to the review is done (with the code merged in the code base). This is important, because it is the time that passes since somebody proposes some change to the code, to the moment that code is merged. Maybe the name of the metric, or the short description, is misleading?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.