Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Candidate Comments (Code Changes Lines) #281

Closed
klumb opened this issue Dec 30, 2019 · 6 comments
Closed

Release Candidate Comments (Code Changes Lines) #281

klumb opened this issue Dec 30, 2019 · 6 comments
Assignees

Comments

@klumb
Copy link
Member

@klumb klumb commented Dec 30, 2019

This issue was created to collect comments about the upcoming metrics release.

This thread is for comments about Code Changes Lines

GitHub location: https://github.com/chaoss/wg-evolution/blob/master/metrics/Code_Changes_Lines.md

See all release candidates of metrics are at:
https://chaoss.community/metrics-202001/

@germonprez

This comment has been minimized.

Copy link
Contributor

@germonprez germonprez commented Jan 13, 2020

"Resources" should be "References"

@ccarterlandis ccarterlandis self-assigned this Jan 14, 2020
@ccarterlandis

This comment has been minimized.

Copy link
Contributor

@ccarterlandis ccarterlandis commented Jan 23, 2020

^^ fixed in #302

@klumb

This comment has been minimized.

Copy link
Member Author

@klumb klumb commented Jan 25, 2020

I am marking this as ready for release and closing. Please reopen if that is not the case.

@klumb klumb closed this Jan 25, 2020
@foundjem

This comment has been minimized.

Copy link
Collaborator

@foundjem foundjem commented Jan 25, 2020

LGTM

Code Changes Lines (Churn)

Some suggestions, under parameter I think the values for parameters should be bold or italicized to make them different from the other text in that line.

For example,
<parameter, --description>

Period of time -- Start and finish date of the period. Default: forever.
The period during which changes are considered.
Criteria for source code -- Algorithm. Default: all files are source code.
If we are focused on source code, we need a criterion for deciding whether a file is a part of the source code or not.
Type of source code change.
-- Lines added
-- Lines removed
-- Whitespace

Signed-off-by: Armstrong foundjem@ieee.org

@GeorgLink

This comment has been minimized.

Copy link
Member

@GeorgLink GeorgLink commented Jan 25, 2020

@foundjem did you already open a pull request? We are preparing the metrics not for release, so any changes you submit via pull request in the next half hour, we can include in the release.

@klumb

This comment has been minimized.

Copy link
Member Author

@klumb klumb commented Jan 25, 2020

I am marking this as ready for release and closing. Please reopen if that is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.