Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Candidate Comments (Reviews Accepted) #282

Closed
klumb opened this issue Dec 30, 2019 · 11 comments · Fixed by #324
Closed

Release Candidate Comments (Reviews Accepted) #282

klumb opened this issue Dec 30, 2019 · 11 comments · Fixed by #324
Assignees

Comments

@klumb
Copy link
Member

@klumb klumb commented Dec 30, 2019

This issue was created to collect comments about the upcoming metrics release.

This thread is for comments about Reviews Accepted

GitHub location: https://github.com/chaoss/wg-evolution/blob/master/metrics/Reviews_Accepted.md

See all release candidates of metrics are at:
https://chaoss.community/metrics-202001/

@germonprez

This comment has been minimized.

Copy link
Contributor

@germonprez germonprez commented Jan 13, 2020

"Resources" should be "References"

@germonprez

This comment has been minimized.

Copy link
Contributor

@germonprez germonprez commented Jan 13, 2020

Un-bold "Question"

@ccarterlandis ccarterlandis self-assigned this Jan 14, 2020
@ccarterlandis

This comment has been minimized.

Copy link
Contributor

@ccarterlandis ccarterlandis commented Jan 14, 2020

@germonprez fixed by #303

@foundjem

This comment has been minimized.

Copy link
Collaborator

@foundjem foundjem commented Jan 25, 2020

LGTM

Some minor suggestions:

  • Add references
  • There is a duplicate entry for
    Mandatory parameters:

Heuristic for detecting accepted pull requests not accepted via the web interface. Default: None.

Signed-off-by: Armstrong Foundjemfoundjem@ieee.org

@klumb

This comment has been minimized.

Copy link
Member Author

@klumb klumb commented Jan 25, 2020

Is this ready for release?

@foundjem do you have specific edits in mind?

@ccarterlandis

This comment has been minimized.

Copy link
Contributor

@ccarterlandis ccarterlandis commented Jan 25, 2020

Barring any specific edits @foundjem may have in mind, I would say it's ready!

@foundjem

This comment has been minimized.

Copy link
Collaborator

@foundjem foundjem commented Jan 25, 2020

My only suggestion was the duplicate entry for Mandatory parameters, else I am good.

@klumb

This comment has been minimized.

Copy link
Member Author

@klumb klumb commented Jan 25, 2020

I believe the mandatory parameters are for the specific platforms. If there is a possibility that the parameters are different for GitHub, GitLab, and Gerrit then I think we need to keep them. @ccarterlandis, what are your thoughts?

@klumb

This comment has been minimized.

Copy link
Member Author

@klumb klumb commented Jan 25, 2020

I am marking this for release. If we need to address unresolved comments, we can do so in the next release.

@klumb klumb closed this Jan 25, 2020
@klumb klumb reopened this Jan 25, 2020
GeorgLink added a commit that referenced this issue Jan 25, 2020
fixes #282  last remaining comment
Signed-off-by: Georg J.P. Link <linkgeorg@gmail.com>
@klumb

This comment has been minimized.

Copy link
Member Author

@klumb klumb commented Jan 25, 2020

Changed mandatory parameters heading style

@klumb

This comment has been minimized.

Copy link
Member Author

@klumb klumb commented Jan 25, 2020

I am marking this as ready for release and closing. Please reopen if that is not the case.

@klumb klumb closed this Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.