Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Candidate Comments (Committers) #73

Closed
germonprez opened this issue Dec 30, 2019 · 8 comments
Closed

Release Candidate Comments (Committers) #73

germonprez opened this issue Dec 30, 2019 · 8 comments

Comments

@germonprez
Copy link
Contributor

@germonprez germonprez commented Dec 30, 2019

This issue was created to collect comments about the upcoming metrics release.

This thread is for comments about Committers

GitHub location: https://github.com/chaoss/wg-risk/blob/master/metrics/Committers.md

See all release candidates of metrics are at:
https://chaoss.community/metrics-202001/

@bproffitt

This comment has been minimized.

Copy link

@bproffitt bproffitt commented Jan 9, 2020

Fixed

In paragraph 1 of "Description," "This is distinct from the more broadly construed "Contributors" CHAOSS metric.." Contributors should be linked to https://github.com/chaoss/wg-common/blob/master/focus-areas/who/contributors.md

** Known Confounds **
This should be a level-3 header, and maybe another word could be used? Confounds is not a commonly used term.

"Provides" in the last paragraph is misspelled.

@sgoggins

This comment has been minimized.

Copy link
Member

@sgoggins sgoggins commented Jan 14, 2020

@bproffitt : Take a look at the edits. I addressed each of your points. I think adding the link is helpful. @klumb and @germonprez may or may not like there being a link. IMHO its not something that is going to be common in the metrics definitions, but in this case, since we are explicitly distinguishing between this metric and another one (committers) I think the link adds usability to the definition and should be in there as you suggest.

@bproffitt

This comment has been minimized.

Copy link

@bproffitt bproffitt commented Jan 14, 2020

Looks good to me!

@klumb

This comment has been minimized.

Copy link
Member

@klumb klumb commented Jan 14, 2020

@sgoggins, I can't speak for @germonprez, but I like the link.

@kestewart

This comment has been minimized.

Copy link
Contributor

@kestewart kestewart commented Jan 20, 2020

"known confound" is a bit awkward.

Suggest also removing modeling information, and add illustration of it in use.

@klumb

This comment has been minimized.

Copy link
Member

@klumb klumb commented Jan 25, 2020

Did PR #86 resolve all comments?

Is this metric ready for release?

@sgoggins

This comment has been minimized.

Copy link
Member

@sgoggins sgoggins commented Jan 25, 2020

Yes. This metric is ready for release, @klumb

@klumb

This comment has been minimized.

Copy link
Member

@klumb klumb commented Jan 25, 2020

I am marking this metric as ready for release and closing. Please reopen if that is not the case.

@klumb klumb closed this Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.