Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Candidate Comments (Test Coverage) #75

Closed
germonprez opened this issue Dec 30, 2019 · 10 comments
Closed

Release Candidate Comments (Test Coverage) #75

germonprez opened this issue Dec 30, 2019 · 10 comments

Comments

@germonprez
Copy link
Contributor

@germonprez germonprez commented Dec 30, 2019

This issue was created to collect comments about the upcoming metrics release.

This thread is for comments about Test Coverage

GitHub location: https://github.com/chaoss/wg-risk/blob/master/metrics/Test_Coverage.md

See all release candidates of metrics are at:
https://chaoss.community/metrics-202001/

@tommens

This comment has been minimized.

Copy link

@tommens tommens commented Jan 1, 2020

The section "Objectives" for this "Test Coverage" metric seems out of place. Its description does not really explain the objectives of the metric. It is very different in style and contents compared to the Objectives sections of the other metrics in the 202001 metrics release.
I would expect to see something along the following lines:
"The objective of the Test Coverage metric is to quantitatively assess the extent to which the code base is tested. It is important to note, however, that a high test coverage is by no means a guarantee for high code quality. Test coverage makes no assessment of the effectiveness of the tests."
If needed, some references could be added (there are many available on the web), such as for example https://www.stickyminds.com/article/100-percent-unit-test-coverage-not-enough

@germonprez

This comment has been minimized.

Copy link
Contributor Author

@germonprez germonprez commented Jan 4, 2020

Thanks @tommens. The objectives sure do seem off :)

@sgoggins could you take a look and see if something was not copied over correctly from the Google doc. If that's not the issue, what do you think of the proposed change?

@sgoggins

This comment has been minimized.

Copy link
Member

@sgoggins sgoggins commented Jan 14, 2020

@tommens and @germonprez : That looks like draft language that got through our edits. At one point it was a more fully described example. Instead of replacing the old, longer example, I put in a short description of the objectives in more general terms. Let me know what you think.

@kestewart

This comment has been minimized.

Copy link
Contributor

@kestewart kestewart commented Jan 20, 2020

From "Open source code coverage tools for common languages like Java, C, and C++ are available from my sites, including this one." Fix reference to "from my sites". Would like to see sample implementations. Image does explain visualizations - like the others.

@germonprez

This comment has been minimized.

Copy link
Contributor Author

@germonprez germonprez commented Jan 20, 2020

Remove the data model and provide a description of the visualization

@germonprez

This comment has been minimized.

Copy link
Contributor Author

@germonprez germonprez commented Jan 20, 2020

C, Java, and Python could be the first candidates for deployment

@klumb

This comment has been minimized.

Copy link
Member

@klumb klumb commented Jan 25, 2020

Is this metric ready for release?

@sgoggins

This comment has been minimized.

Copy link
Member

@sgoggins sgoggins commented Jan 25, 2020

@sgoggins

This comment has been minimized.

Copy link
Member

@sgoggins sgoggins commented Jan 25, 2020

@klumb : Ready for release.

@klumb

This comment has been minimized.

Copy link
Member

@klumb klumb commented Jan 25, 2020

I am marking this metric as ready for release and closing. Please reopen if that is not the case.

@klumb klumb closed this Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.