Shield Updates #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
chaosvolt
commented
Feb 4, 2020
chaosvolt
commented
- Bumped all WBLOCK_1 shields up to WBLOCK_2. Having bucklers massively better at blocking than full-size shields was an ancient mistake on my part, and it made basic-tier shields way less useful than they should be.
- Updated coverage percentage. You know all those values under 50 percent? That was a holdover from the way shields were before I PR'd them. Before BLOCK_WHILE_WORN, when shields faked blocking via covering the torso and head, meaning cover percent was used to fake block chance. Those values were never fixed after all this time.
- Updated item encumbrance, with a higher degree of standardization. The oddball values were also a relic from the days when shields were armor covering the torso and head. Means a bit more encumbrance for the basic makeshift wooden shield, but less encumbrance for the higher-quality shields.
* Bumped all WBLOCK_1 shields up to WBLOCK_2. Having bucklers massively better at blocking than full-size shields was an ancient mistake on my part, and it made basic-tier shields way less useful than they should be. * Updated coverage percentage. You know all those values under 50 percent? That was a holdover from the way shields were before I PR'd them. Before BLOCK_WHILE_WORN, when shields faked blocking via covering the torso and head, meaning cover percent was used to fake block chance. Those values were never fixed after all this time. * Updated item encumberance, with a higher degree of standardization. The oddball values were also a relic from the days when shields were armor covering the torso and head. Means a bit more encumberance for the basic makeshift wooden shield, but less encumberance for the higher-quality shields.
|
Good changes, nice to see the shields being worked on, i like playing with them occasionally. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.