Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

constify ShaderReflection::Get*() methods #4

Closed
cdwfs opened this issue Oct 9, 2017 · 5 comments
Closed

constify ShaderReflection::Get*() methods #4

cdwfs opened this issue Oct 9, 2017 · 5 comments

Comments

@cdwfs
Copy link
Collaborator

cdwfs commented Oct 9, 2017

GetDescriptor(), GetDescriptorSet(), GetInputVariable(), and GetOutputVariable() aren't tagged as const. Any reason they couldn't be? Also, why do they return "Foo* const" instead of "const Foo*"?
@cdwfs
Copy link
Collaborator Author

cdwfs commented Oct 9, 2017

Looks like FindType() may also be a candidate for const'ing.

@cdwfs
Copy link
Collaborator Author

cdwfs commented Oct 9, 2017

Please ignore; I was on the wrong branch.

@cdwfs cdwfs closed this as completed Oct 9, 2017
@cdwfs cdwfs reopened this Oct 10, 2017
@cdwfs
Copy link
Collaborator Author

cdwfs commented Oct 10, 2017

Same question re: the return values from spvReflectGet*() in the non-opaque branch. Is there a reason they don't return "const SpvReflectFoo*" instead of "SpvReflectFoo*"?

@chaoticbob
Copy link
Contributor

There is a yet to be implemented part of the API that lets you modify set#, binding#, and location#. Left as non-const to allow for this.

@chaoticbob
Copy link
Contributor

This should all be sorted out since that part of the API is implemented. Const has been applied to the appropriate places.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chaoticbob @cdwfs