Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we have a module/user code equivalent of --verify? #18417

Open
e-kayrakli opened this issue Sep 13, 2021 · 1 comment
Open

Should we have a module/user code equivalent of --verify? #18417

e-kayrakli opened this issue Sep 13, 2021 · 1 comment

Comments

@e-kayrakli
Copy link
Contributor

The Chapel compiler has a --verify flag that's mainly used by developers/nightly testing to sanity check the AST and the state of the compiler. Should we have a module level flag that gets set with --verify or have something separate but equivalent?

This came about when we noticed a performance issue with a verification for a string optimization that happened with --boundsChecking. This verification was too slow to the extent that it was causing testing to timeout. More references for this context:

Are there other potential use cases for this verification? Things that I can think of besides the string metadata caching are:

  • UTF-8 validation during string deinit and/or string methods that assumes UTF-8 data
  • Constant domain optimization: we could halt if operator = is called on a domain where definedConst is set.
  • We can make localAccess do a check on the index and halt if it isn't local. (Currently, I think we get an OOB error that might look a little strange to the user)
@mppf
Copy link
Member

mppf commented Sep 14, 2021

I think it'd be reasonable to add such a variable. If we do, we should document it in https://chapel-lang.org/docs/main/technotes/globalvars.html .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants