Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add native implementation of inv (Gauss-Jordan Elimination) #16255

Closed
wants to merge 23 commits into from
Closed

Add native implementation of inv (Gauss-Jordan Elimination) #16255

wants to merge 23 commits into from

Conversation

rahulghangas
Copy link
Member

@rahulghangas rahulghangas commented Aug 19, 2020 •
edited
Loading

  • Add inplace implementation
  • Testing

@rahulghangas
Copy link
Member Author

@ben-albrecht needs label gsoc:LinearAlgebra

@rahulghangas rahulghangas changed the title Add native implementation of inv - implements gaussian elimination Add native implementation of inv (gaussian elimination) Aug 19, 2020
@rahulghangas rahulghangas changed the title Add native implementation of inv (gaussian elimination) Add native implementation of inv (Gauss-Jordan Elimination) Aug 20, 2020
@rahulghangas rahulghangas marked this pull request as ready for review August 20, 2020 11:30
@rahulghangas rahulghangas marked this pull request as draft August 20, 2020 12:27
ben-albrecht
ben-albrecht reviewed Aug 26, 2020
View reviewed changes
Copy link
Member

@ben-albrecht ben-albrecht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments.

modules/packages/LinearAlgebra.chpl Outdated Show resolved Hide resolved
modules/packages/LinearAlgebra.chpl
halt("Wrong rank for matrix inverse");

if !isSquare(A) then
halt("Matrix inverse only supports square matrices");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be a compilerError

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compilerError doesn't work if the argument to inv is a call to another function that returns a 2-D matrix. halt does

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a bug in the compiler to me... Do you have a short example demonstrating this?

modules/packages/LinearAlgebra.chpl Outdated Show resolved Hide resolved
modules/packages/LinearAlgebra.chpl Outdated Show resolved Hide resolved
@rahulghangas rahulghangas marked this pull request as ready for review August 31, 2020 03:31
@rahulghangas @ben-albrecht
Typo in documentation
fcbc6f8 
Co-authored-by: Ben Albrecht <ben-albrecht@users.noreply.github.com>
@e-kayrakli
Copy link
Contributor

@rahulghangas

Add inplace implementation

Is this still a todo? If not, and this is ready for a review, could you update the PR message and let us know, so we move forward with this.

If it is still a todo let us know if you can/want to work on it soon.

@e-kayrakli
Copy link
Contributor

Based on silence, I am closing this PR.

@rahulghangas -- Please feel free to reopen when you have the time to work on this.

@e-kayrakli e-kayrakli closed this Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-albrecht ben-albrecht ben-albrecht left review comments

Assignees
No one assigned
Labels
post-release stat: cla signed stat: developed under CLA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rahulghangas @e-kayrakli @ben-albrecht @bradcray @chapelautomaton