[GSOC] Qthread Select #18019
Merged
[GSOC] Qthread Select #18019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnadey30
approved these changes
Jul 3, 2021
king-11
commented
Jul 7, 2021
king-11
force-pushed
the
qt_sys_calls
branch
2 times, most recently
from
f3435c5
to
839372d
Compare
king-11
force-pushed
the
qt_sys_calls
branch
3 times, most recently
from
c278e95
to
83ebb6d
Compare
|
I've run testing with this but I see these failures While this is a testing problem, I'm not quite sure how to solve it. These tests try to compile some C code with some C files from the runtime to check that they work. Can we disable the qthreads integration if |
|
Made the required updates @mppf |
mppf
reviewed
Jul 29, 2021
mppf
reviewed
Jul 29, 2021
mppf
reviewed
Jul 29, 2021
|
@king-11 - let me know when you've addressed the feedback and I'll run testing again. Thanks. |
qt sys calls handle blocking sys calls whenever qthreads are available to us keeping the orginal thread unblocked Signed-off-by: Lakshya Singh <lakshay.singh1108@gmail.com>
king-11
force-pushed
the
qt_sys_calls
branch
6 times, most recently
from
b1d511f
to
e91ad0b
Compare
mppf
reviewed
Jul 29, 2021
mppf
reviewed
Jul 29, 2021
king-11
force-pushed
the
qt_sys_calls
branch
3 times, most recently
from
ecfdd3b
to
41a11b1
Compare
mppf
reviewed
Jul 30, 2021
mppf
reviewed
Jul 30, 2021
allow blocking select for small timeout don't compile with qt_select in test env after which we call qt_select or blocking select based on availability busy wait select doesn't work hence is commented out for time being Signed-off-by: Lakshya Singh <lakshay.singh1108@gmail.com>
|
Looking good. I'd like to run testing again before merging. |
|
Passed full local testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conditional compilation of
qt_selectfor providing in a method to keep original task unblocked when observing for IO.Prior to
qt_selectcallselectand block for 64ms which allows instantaneous connections to be establishedwithout timing out.
Signed-off-by: Lakshya Singh lakshay.singh1108@gmail.com